Closed Bug 1231808 Opened 6 years ago Closed 6 years ago

Hide "Pause" button from infobar

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox44 unaffected, firefox45+ fixed, firefox46+ fixed, firefox-esr38 unaffected)

RESOLVED FIXED
mozilla46
Tracking Status
firefox44 --- unaffected
firefox45 + fixed
firefox46 + fixed
firefox-esr38 --- unaffected

People

(Reporter: RT, Assigned: dcritchley)

References

()

Details

(Keywords: privacy, regression, sec-moderate)

User Story

There is a pause button on the infobar even if the pause functionality is not implemented.
We should hide that button until the functionality is implemented.

Attachments

(1 file, 1 obsolete file)

No description provided.
Blocks: 1209713
Rank: 10
User Story: (updated)
Priority: -- → P1
Manu - is this something you can help with?
Flags: needinfo?(b.mcb)
Assignee: nobody → dcritchley
(In reply to Romain Testard [:RT] from comment #1)
> Manu - is this something you can help with?

I'll grab this bug
Flags: needinfo?(b.mcb)
TODO: Add class to stop, resume, pause buttons to differentiate. Use button class to identify pause (and perhaps resume button) and hide within notification[value="loop-sharing-notification"] .notification-button
Suggest: 
    notification[value="loop-sharing-notification"] .notification-button.close-btn,
    notification[value="loop-sharing-notification"] .notification-button.resume-btn { display:none; }

Affected file(s): 
    /loop/addon/chrome/skin/shared/loop.css
    /loop/addon/chrome/skin/osx/platform.css
You need to get a review before merging to master
Attachment #8698734 - Flags: review?(standard8)
Attachment #8698734 - Flags: review?(edilee)
Attachment #8698734 - Flags: review?(dmose)
Comment on attachment 8698734 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/14

Dave, the changes look reasonable, but I think you need to land them on a new branch, and create a new PR against latest master before we can review them fully.
Attachment #8698734 - Flags: review?(standard8)
Attachment #8698734 - Flags: review?(edilee)
Attachment #8698734 - Flags: review?(dmose)
Attachment #8698734 - Attachment is obsolete: true
Attachment #8700196 - Flags: review?(standard8)
Comment on attachment 8700196 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/25

r=Standard8, but please make sure the commit message is changed before doing a fast-forward merge:

Bug 1231808 - Hide pause from Info bar until bug 1220608 is fixed. r=Standard8
Attachment #8700196 - Flags: review?(standard8) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
I was testing things out this morning, and found that Nightly 46.0a1 (2016-01-05) still has a pause button, even though it still doesn't do anything.

I get that this is just Nightly, but this is *far* more than a cosmetic defect. This is a really big security and privacy issue. You have controls and clear indicia that a user's tab has been made private, when you are actually streaming out everything they do to another user. Even for Nightly users, that's an unacceptable breach of trust.

Marking as sec-moderate. We really need a fix to land on m-c ASAP.
Status: RESOLVED → REOPENED
Keywords: sec-moderate
Resolution: FIXED → ---
(In reply to Adam Roach [:abr] from comment #9)
> Marking as sec-moderate. We really need a fix to land on m-c ASAP.

As per the previous comment, this has landed in fx-team and will merge at the next merge time.
https://hg.mozilla.org/mozilla-central/rev/3c7d6b80345e
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment on attachment 8700196 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/25

Approval Request Comment
[Feature/regressing bug #]: 1214214
[User impact if declined]: Rather severe privacy intrusion; see comment 9
[Describe test coverage new/current, TreeHerder]: N/A -- this removes a button
[Risks and why]: Low. This landed on m-c and works well
[String/UUID change made/needed]: None

Tagging Mark as n-i, in case the patch needs any modifications to land on mozilla-aurora.
Flags: needinfo?(standard8)
Attachment #8700196 - Flags: approval-mozilla-aurora?
Blocks: 1214214
(In reply to Adam Roach [:abr] from comment #13)
> Tagging Mark as n-i, in case the patch needs any modifications to land on
> mozilla-aurora.

Transplanting the landed changeset works fine.
Flags: needinfo?(standard8)
(In reply to Adam Roach [:abr] from comment #13)

> [Risks and why]: Low. This landed on m-c and works well

To be clear, this is a CSS change that only impacts the Hello feature. The scope of impact is limited to Hello, and the chances of this impacting anything other than the offending button are extremely slim.
Comment on attachment 8700196 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/25

Minor css change, Makes sense to hide the button to help protect user privacy. 
Please uplift to aurora.
Attachment #8700196 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Mark -- I'm tagging you to uplift this, to make sure it doesn't fall between the cracks.
Flags: needinfo?(standard8)
You need to log in before you can comment on or make changes to this bug.