1231813 - The ID of the format internal storage button in Settings/Media Storage has changed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Michael Bryant (uber)]

03:51:38 26:42.70 TEST_START: MainThread test_settings_storage_RTL.py TestSettingsRTL.test_settings_app_disable_USB_storage
03:53:19 28:23.20 TEST_END: MainThread ERROR, expected PASS
03:53:19 Traceback (most recent call last):
03:53:19   File "/var/jenkins/1/workspace/flame-kk-512.mozilla-central.nightly.ui.graphics.arabic.RTL/.env/local/lib/python2.7/site-packages/marionette_client-2.0.0-py2.7.egg/marionette/marionette_test.py", line 344, in run
03:53:19     testMethod()
03:53:19   File "/var/jenkins/1/workspace/flame-kk-512.mozilla-central.nightly.ui.graphics.arabic.RTL/.env/local/lib/python2.7/site-packages/marionette_client-2.0.0-py2.7.egg/marionette/marionette_test.py", line 222, in wrapper
03:53:19     return func(self, *args, **kwargs)
03:53:19   File "/var/jenkins/1/workspace/flame-kk-512.mozilla-central.nightly.ui.graphics.arabic.RTL/tests/python/gaia-ui-tests/gaiatest/tests/graphics/RTL/test_settings_storage_RTL.py", line 40, in test_settings_app
03:53:19     mediastorage_page.internal_storage.tap_format()
03:53:19   File "/var/jenkins/1/workspace/flame-kk-512.mozilla-central.nightly.ui.graphics.arabic.RTL/tests/python/gaia-ui-tests/gaiatest/apps/settings/regions/storage_region.py", line 44, in tap_format
03:53:19     Wait(self.marionette).until(expected.element_displayed(*self._format_dialog_confirm_locator))
03:53:19   File "/var/jenkins/1/workspace/flame-kk-512.mozilla-central.nightly.ui.graphics.arabic.RTL/.env/local/lib/python2.7/site-packages/marionette_driver-1.1.1-py2.7.egg/marionette_driver/wait.py", line 143, in until
03:53:19     cause=last_exc)
03:53:19 TimeoutException: TimeoutException: Timed out after 10.3 seconds

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ubermarklar:1231813 > mozilla-b2g:master

Comment 2

[Michael Bryant (uber)]

Comment on attachment 8697636 [details] [review]
[gaia] ubermarklar:1231813 > mozilla-b2g:master

The ID locators have changed so we've had to change them in the test scripts to navigate to the proper locations.

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8697636 [details] [review]
[gaia] ubermarklar:1231813 > mozilla-b2g:master

The dialog buttons should normally have their own pageregion, but we're not trying to improve Gaia UI tests anymore, so this is fine.

Comment 4

[No-Jun Park [:njpark]]

Merged:
https://github.com/mozilla-b2g/gaia/commit/88fe1b7d342faa9cef5433167ff83213d1becd8c

Good, this is your first contribution to gaia, Michael.(and there will be tons more to do)