Open Bug 1231823 Opened 4 years ago Updated 10 months ago

uclinux may not have dlfcn.h

Categories

(NSPR :: NSPR, defect)

4.11
defect
Not set

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: andrew.cagney, Assigned: wtc)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch handle no dlfcn.h on linux (obsolete) — Splinter Review
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151102093849

Steps to reproduce:

uClinux (a linux variant) may not have dlfcn.h (and the associated dlopen() et.al. functions).  This patch handles this.

It's intended to be minimal - just modifying linux.



Expected results:

nspr cross compiles for a uclinux target that doesn't have dhfcn.h.
Attachment #8697401 - Flags: superreview?(ted)
Attachment #8697401 - Flags: review?(mh+mozilla)
Comment on attachment 8697401 [details] [diff] [review]
handle no dlfcn.h on linux

Review of attachment 8697401 [details] [diff] [review]:
-----------------------------------------------------------------

::: nspr-4.11/nspr/pr/src/pthreads/ptthread.c.orig
@@ +19,4 @@
>  #include <unistd.h>
>  #include <string.h>
>  #include <signal.h>
> +#ifdef HAVE_DLFCN_H

Seems to me you want USE_DLFCN here.

@@ +1766,4 @@
>      int (*dynamic_pthread_setname_np)(pthread_t, const char*);
>  #endif
>  
> +#if defined(HAVE_DLL)

and here.
Attachment #8697401 - Flags: review?(mh+mozilla)
Per requested tweaks.
Attachment #8697401 - Attachment is obsolete: true
Attachment #8697401 - Flags: superreview?(ted)
Attachment #8699464 - Flags: review+
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
You need to log in before you can comment on or make changes to this bug.