Closed Bug 1231888 Opened 4 years ago Closed 4 years ago
Cairo Pixman Bug Workaround
AutoCairoPixmanBugWorkaround (added in bug 364968) doesn't seem to be necessary any more.
Try server looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c5969d4a12b
Attachment #8697487 - Flags: review?(vladimir)
Comment on attachment 8697487 [details] [diff] [review] Remove AutoCairoPixmanBugWorkaround I'm not familiar with AutoCairoPixmanBugWorkaround -- Jeff should be able to say whether it's safe to remove..
Attachment #8697487 - Flags: review?(vladimir) → review?(jmuizelaar)
Continuing the discussion from bug 364968... > > Oh wait, I think the code you added to fix this ended up being modified into > > AutoCairoPixmanBugWorkaround? But if I remove AutoCairoPixmanBugWorkaround > > the test seems to work fine, so maybe it can now be removed... > > Is the work around being triggered if you leave it in? I can trigger it (i.e. reach the end of AutoCairoPixmanBugWorkaround and set |mPushed| to true) in these two tests: ./layout/reftests/image-element/bug-364968.html ./layout/reftests/bugs/364968-1.xul But as the try server results from comment 1 indicate, these tests pass even when AutoCairoPixmanBugWorkaround is removed. So AFAICT the bug being worked around no longer exists in Cairo. (Or those tests don't correctly test for the bug; hopefully that's not the case, though it's hard to tell for sure.) What do you think?
Comment on attachment 8697487 [details] [diff] [review] Remove AutoCairoPixmanBugWorkaround Review of attachment 8697487 [details] [diff] [review]: ----------------------------------------------------------------- Let's give it a try. We can always back it out.
Attachment #8697487 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0230310c95626cedf12ff2354b397f48ce265a47 Bug 1231888 - Remove AutoCairoPixmanBugWorkaround. r=jrmuizel.
The previous patch in this bug removed two calls to CurrentSurface(), leaving only one, and that one doesn't need the dx and dy arguments.
Attachment #8706695 - Flags: review?(jmuizelaar)
Attachment #8706695 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d4f53b5744d74accdb9a858c489d4292483a70d Bug 1231888 (follow-up) - Simplify CurrentSurface(). r=jrmuizel.
You need to log in before you can comment on or make changes to this bug.