Closed
Bug 1231896
Opened 8 years ago
Closed 8 years ago
Recent tabs are not restored after a tab with an invalid address
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox43 affected, firefox44 affected, firefox45 affected, firefox46 verified)
RESOLVED
FIXED
Firefox 46
People
(Reporter: TeoVermesan, Assigned: Margaret)
Details
Attachments
(1 file)
Steps to reproduce: 1. Open gmail.com, youtube.com, about:apps (invalid address), facebook.com, google.com 2. Close Firefox by swiping it from task manager 3. Reopen Firefox 4. Go to "Recent Tabs" - Tabs from last time and choose "Open all" Expected results: - All 5 tabs are reopened in new tabs. Actual results: - Only gmail.com, youtube.com and about:apps are restored. Other tabs opened after about:apps are not loaded Note: -reproducible on all branches
Assignee | ||
Comment 1•8 years ago
|
||
I see this error in the log: 12-11 09:24:59.520 19550 19567 D GeckoBrowser: Handled load error: [Exception... "Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIWebNavigation.loadURIWithOptions]" nsresult: "0x804b000a (NS_ERROR_MALFORMED_URI)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: loadURIWithFlags :: line 154" data: no] 12-11 09:24:59.524 19550 19567 E GeckoConsole: [JavaScript Error: "NS_ERROR_MALFORMED_URI: Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsISHistory.reloadCurrentEntry]" {file: "jar:jar:file:///data/app/org.mozilla.fennec_leibovic-1/base.apk!/assets/omni.ja!/components/SessionStore.js" line: 1006}]
Assignee: nobody → margaret.leibovic
Assignee | ||
Comment 2•8 years ago
|
||
Bug 1231896 - Catch exception thrown if we fail to reload session state for error page. r=bnicholson
Attachment #8697548 -
Flags: review?(bnicholson)
Assignee | ||
Comment 3•8 years ago
|
||
This might be a shitty patch, but at least it stops the error from propagating.
Comment 4•8 years ago
|
||
Comment on attachment 8697548 [details] MozReview Request: Bug 1231896 - Catch exception thrown if we fail to reload session state for error page. r=bnicholson https://reviewboard.mozilla.org/r/27623/#review24981 Looks fine to me!
Attachment #8697548 -
Flags: review?(bnicholson) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/caee0e6ab22e0084dcb65e78ebdd7407c5ba7ec4 Bug 1231896 - Catch exception thrown if we fail to reload session state for error page. r=bnicholson
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/caee0e6ab22e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Reporter | ||
Comment 7•8 years ago
|
||
After closing gmail.com, youtube.com, about:apps, facebook.com, google.com and reopen them from "Recent Tabs" panel, all 5 tabs are reopened in new tabs, so: Verified as fixed using: Device: Samsung Galaxy Tab S2 (Android 5.0.2) Build: Firefox for Android 46.0a1 (2015-12-17)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•