Run mach build, mach artifact install and mach package in one command

RESOLVED WONTFIX

Status

()

Firefox for Android
Build Config & IDE Support
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: alex_johnson, Assigned: alex_johnson)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
It would be helpful to be able to run mach build, mach artifact install and mach package in one command.
(Assignee)

Comment 1

3 years ago
Created attachment 8697553 [details]
MozReview Request: Bug 1231928 - A script to run mach build, mach artifact install and mach package at once. r?nalexander

Bug 1231928 - A script to run mach build, mach artifact install and mach package at once. r?nalexander
Attachment #8697553 - Flags: review?(nalexander)
(Assignee)

Updated

3 years ago
Assignee: nobody → alex_johnson24
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Comment on attachment 8697553 [details]
MozReview Request: Bug 1231928 - A script to run mach build, mach artifact install and mach package at once. r?nalexander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27627/diff/1-2/
Comment on attachment 8697553 [details]
MozReview Request: Bug 1231928 - A script to run mach build, mach artifact install and mach package at once. r?nalexander

https://reviewboard.mozilla.org/r/27627/#review25015

Hi Alex,

Thanks for thinking of this.  The intention is good, but as written, it doesn't fit with how we structure commands.  There are a few points I'd like to surface.

First, we have the `mach` package to enable commands.  Look at https://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=path%3Amach_commands.py&redirect=true for examples.  (You can see `mach artifact` itself in https://dxr.mozilla.org/mozilla-central/source/mobile/android/mach_commands.py#195).

Second, we generally don't distribute wrap up commands of this sort.  Folks have different workflows and we generally expect an explosion of shell aliases; shipping them all isn't viable.

Third, and most importantly, we *do* want to make this better.  https://bugzilla.mozilla.org/show_bug.cgi?id=1216817 tracks making the `mach artifact` business happen automatically, and I'm always making the Gradle and IDE configuration more automatic.

If you'd like to pursue this idea, I think we should build it as a `mach` command and discuss it with the broader community.  We've had `mach build && mach package && mach install` for a really long time; I'm loathe to change that (even to add an alternate) without consensus.  Discussion should happen on https://mail.mozilla.org/listinfo/mobile-firefox-dev.

Finally, I'd like to know if you were lead to this by bad documentation or just by convenience.  Thanks again!
Attachment #8697553 - Flags: review?(nalexander)
https://reviewboard.mozilla.org/r/27627/#review25017

Hi Alex,

Thanks for thinking of this.  The intention is good, but as written, it doesn't fit with how we structure commands.  There are a few points I'd like to surface.

First, we have the `mach` package to enable commands.  Look at https://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=path%3Amach_commands.py&redirect=true for examples.  (You can see `mach artifact` itself in https://dxr.mozilla.org/mozilla-central/source/mobile/android/mach_commands.py#195).

Second, we generally don't distribute wrap up commands of this sort.  Folks have different workflows and we generally expect an explosion of shell aliases; shipping them all isn't viable.

Third, and most importantly, we *do* want to make this better.  https://bugzilla.mozilla.org/show_bug.cgi?id=1216817 tracks making the `mach artifact` business happen automatically, and I'm always making the Gradle and IDE configuration more automatic.

If you'd like to pursue this idea, I think we should build it as a `mach` command and discuss it with the broader community.  We've had `mach build && mach package && mach install` for a really long time; I'm loathe to change that (even to add an alternate) without consensus.  Discussion should happen on https://mail.mozilla.org/listinfo/mobile-firefox-dev.

Finally, I'd like to know if you were lead to this by bad documentation or just by convenience.  Thanks again!
(Assignee)

Comment 5

3 years ago
Nick,

Thanks for the clarification.  

I was lead to this for just convenience; nothing wrong with the documentation.

I'm definitely looking forward to the day we can start gradle building Fennec.

I'm gonna set this to resolved wontfix then.

Thanks! :)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.