Closed
Bug 1231943
Opened 9 years ago
Closed 9 years ago
Add basic telemetry for memory tools
Categories
(DevTools :: Memory, defect)
DevTools
Memory
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: jsantell, Assigned: jsantell)
Details
Attachments
(1 file)
6.17 KB,
patch
|
benjamin
:
feedback+
|
Details | Diff | Splinter Review |
Need telemetry for basic opening of memory tools
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8697568 -
Flags: review?(nfitzgerald)
Comment 2•9 years ago
|
||
Comment on attachment 8697568 [details] [diff] [review] 1231943-memory-telemetry.patch Review of attachment 8697568 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, don't forget to flag bsmedberg or another data peer for additional review.
Attachment #8697568 -
Flags: review?(nfitzgerald) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8697568 [details] [diff] [review] 1231943-memory-telemetry.patch Basic telemetry for seeing if the new memory tool is being used -- we missed this when shipping in Fx44
Attachment #8697568 -
Flags: review+ → review?(benjamin)
Comment 4•9 years ago
|
||
Comment on attachment 8697568 [details] [diff] [review] 1231943-memory-telemetry.patch In general sounds fine: who is responsible for monitoring this data in perpetuity, and which dashboard(s) do they use?
Flags: needinfo?(jsantell)
Assignee | ||
Comment 5•9 years ago
|
||
The devtools team (fitzgen and I) and our own dashboards for monitoring tool usage: http://devtools-dash.paas.canuckistani.ca/tools-relative.html
Flags: needinfo?(jsantell)
Comment 6•9 years ago
|
||
Comment on attachment 8697568 [details] [diff] [review] 1231943-memory-telemetry.patch Excellent. Note that I'm not a code reviewer for this, so I'm gonig to mark data-review+ and let some code peer do any review.
Attachment #8697568 -
Flags: review?(benjamin) → feedback+
Assignee | ||
Comment 7•9 years ago
|
||
Fitzgen already reviewed code, so checkin-needed; thanks to both!
Keywords: checkin-needed
Comment 9•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/22aa3e580b1d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment 10•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•