1231945 - Display animation ID in the animation inspector timeline

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, defect)

Description

[Patrick Brosset <:pbro>]

In the animation timeline, each displayed animation has got a name label.

For css animations it's the @keyframes rule name.
For css transitions it's the transitioned property.

The WebAnimations API also introduces JS-generated animations and that's being implemented now. These can get an ID defined by authors.
Using the API, authors can also set IDs for CSS animations.

So, we should change the way the animation name is retrieved in the AnimationPlayerActor so that, if there's an ID, then use this.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1231945 - Display animation.id when it exists; r=tromey

Review commit: https://reviewboard.mozilla.org/r/33235/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33235/

Comment 2

[Patrick Brosset <:pbro>]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebd52de973c8&group_state=expanded

Comment 3

[Tom Tromey :tromey]

Comment on attachment 8714733 [details]
MozReview Request: Bug 1231945 - Display animation.id when it exists; r=tromey

https://reviewboard.mozilla.org/r/33235/#review29997

Looks great.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/673d0e96112b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/673d0e96112b