Closed Bug 1231956 Opened 4 years ago Closed 4 years ago

Add devtools files to .eslintignore

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: miker, Assigned: mossop, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good-first-bug lang=js])

Attachments

(1 file)

Run ./mach eslint and add all devtools files that have warnings or errors to .eslintignore so that `./mach eslint` at root level passes.
Whiteboard: [good-first-bug lang=js]
Blocks: 1229859
I am new to open source community. Can I work on this bug? This being my first bug I will probably need lots of help.
I think we can proceed in steps.
First step would be to ignore the whole devtools/ directory. Which would mean adding 'devtools/**' in this file: https://dxr.mozilla.org/mozilla-central/source/.eslintignore
Second steps would be enabling directories one by one, and adding specific exclusion in .eslintignore. But that should be done as a child bug of bug 1231957.

Not so sure this is a good first bug after all in fact.
Devtools has a lot of eslint failures right now that would block us from turning
on compile time eslint checks in bug 1229588. For now I'd like to just ignore
the directory and then you can work to clean up the warnings and re-enable
checks at whatever pace you like.

Review commit: https://reviewboard.mozilla.org/r/30405/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30405/
Attachment #8706617 - Flags: review?(pbrosset)
Comment on attachment 8706617 [details]
MozReview Request: Bug 1231956: Add devtools to .eslintignore. r?pbro

https://reviewboard.mozilla.org/r/30405/#review27213

Thanks for taking care of this Dave.
Can you remind me how we can still run ESLint locally with the folder excluded though? I know there's a way.
Attachment #8706617 - Flags: review?(pbrosset) → review+
(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #4)
> Comment on attachment 8706617 [details]
> MozReview Request: Bug 1231956: Add devtools to .eslintignore. r?pbro
> 
> https://reviewboard.mozilla.org/r/30405/#review27213
> 
> Thanks for taking care of this Dave.
> Can you remind me how we can still run ESLint locally with the folder
> excluded though? I know there's a way.

Add --no-ignore to the command line.
Assignee: nobody → dtownsend
https://hg.mozilla.org/mozilla-central/rev/2feec42daf62
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.