Prompt to install hgwatchman on OS X

RESOLVED FIXED in Firefox 45

Status

Firefox Build System
Mach Core
RESOLVED FIXED
3 years ago
4 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

unspecified
mozilla45
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
We should prompt to install hgwatchman during `mach mercurial-setup`. To make this bug easier, I'm going to limit this to OS X since we'll need to perform kernel tuning on Linux so watchman doesn't hit inotify limits and implementing this is slightly more complicated.
(Assignee)

Comment 1

3 years ago
Created attachment 8697628 [details]
MozReview Request: Bug 1231989 - Install watchman via Homebrew and MacPorts; r?ahal

Bug 1231989 - Install watchman via Homebrew and MacPorts; r?ahal

This is needed to support hgwatchman.
Attachment #8697628 - Flags: review?(ahalberstadt)
(Assignee)

Comment 2

3 years ago
Created attachment 8697629 [details]
MozReview Request: Bug 1231989 - Prompt to install hgwatchman extension; r?ahal

Bug 1231989 - Prompt to install hgwatchman extension; r?ahal

This can speed up performance significantly.

Only support OS X for now because on Linux we have to adjust inode
limits to support mozilla-central and I don't feel like scope bloating.
Attachment #8697629 - Flags: review?(ahalberstadt)
Attachment #8697628 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8697628 [details]
MozReview Request: Bug 1231989 - Install watchman via Homebrew and MacPorts; r?ahal

https://reviewboard.mozilla.org/r/27673/#review24901
Comment on attachment 8697629 [details]
MozReview Request: Bug 1231989 - Prompt to install hgwatchman extension; r?ahal

https://reviewboard.mozilla.org/r/27675/#review24903
Attachment #8697629 - Flags: review?(ahalberstadt) → review+

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/93234b5d4fef
https://hg.mozilla.org/mozilla-central/rev/4f20f5949170
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

Updated

3 years ago
Depends on: 1234394

Updated

3 years ago
Depends on: 1234396

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.