1232004 - Use .svg for the Windows twisties after bug 1191230

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Bug 1191230 updates the tree twisties to svg images. To not break our use of the twisties we need to follow on Windows to use the svg images.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: twisty.svg.patch

This simply changes from png to svg. On chat files I added %ifdef XP_WIN to use the svg files.

Bug 1191230 is now checkin-needed and lands hopefully until Monday.

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8697640 [details] [diff] [review]
twisty.svg.patch

Review of attachment 8697640 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/im/themes/chat.css
@@ +530,5 @@
>    width: 9px; /* The image's width is 9 pixels */
>    height: 9px;
>    -moz-margin-end: 3px;
>    -moz-margin-start: 3px;
> +  background: url("chrome://global/skin/tree/twisty.svg#open") no-repeat center;

Doesn't this and im/themes/blist.css also apply to all operating systems? Why are they not ifdefed?

Comment 3

[Richard Marti (:Paenglab)]

No, because the full block is this:

/* from instantbird/themes/blist.css */
%ifdef XP_WIN
imgroup .twisty {
  padding-top: 1px;
  width: 9px; /* The image's width is 9 pixels */
  height: 9px;
  -moz-margin-end: 3px;
  -moz-margin-start: 3px;
  background: url("chrome://global/skin/tree/twisty.svg#open") no-repeat center;
}

imgroup[closed] .twisty {
  background: url("chrome://global/skin/tree/twisty.svg#clsd") no-repeat center;
}
%else

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8697640 [details] [diff] [review]
twisty.svg.patch

Review of attachment 8697640 [details] [diff] [review]:
-----------------------------------------------------------------

Ahh, of course! Thanks for the explanation!

Comment 5

[Richard Marti (:Paenglab)]

http://hg.mozilla.org/comm-central/rev/f0294b557494

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 8697640 [details] [diff] [review]
twisty.svg.patch

[Approval Request Comment]
Regression caused by (bug #): 1191230, which also has approval for aurora requested
User impact if declined: no visible twisties
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): very low, only CSS changes

Comment 7

[Richard Marti (:Paenglab)]

Bug 1191230 landed now on aurora. This bug should also land on aurora to show all twisties.

Comment 8

[Jorg K (CEST = GMT+2)]

Aurora:
https://hg.mozilla.org/releases/comm-aurora/rev/7b974b565a71