Closed Bug 1232038 Opened 4 years ago Closed 4 years ago

Fix assertion errors in clang-plugin

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: Nika, Assigned: Nika)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Currently enabling assertions in the clang plugin will cause it to crash on tests.

That's bad. So we should fix it. Ideally, the tests should also be run with at least assertions turned on, to prevent this in the future.
Adding dep because enabling assertions will be annoying unless we can set flags to be used for building clang-plugin!
Depends on: 1231980
Do you remember what these assertions were by any chance?  For example, I'm hitting things like "Name is not a simple identifier" and others.  I have a fix for that one...
Depends on: 1245275
With these changes (and bug 1278135), the clang plugin no longer asserts when I run it in an assertions-enabled build!
Attachment #8760103 - Flags: review?(ehsan)
Depends on: 1278135
Attachment #8760103 - Flags: review?(ehsan) → review+
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/744db8f3ad0c
Fix assertion errors in the clang plugin, r=ehsan
https://hg.mozilla.org/mozilla-central/rev/744db8f3ad0c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.