Currently enabling assertions in the clang plugin will cause it to crash on tests. That's bad. So we should fix it. Ideally, the tests should also be run with at least assertions turned on, to prevent this in the future.
Adding dep because enabling assertions will be annoying unless we can set flags to be used for building clang-plugin!
Depends on: 1231980
Do you remember what these assertions were by any chance? For example, I'm hitting things like "Name is not a simple identifier" and others. I have a fix for that one...
Created attachment 8760103 [details] [diff] [review] Fix assertion errors in the clang plugin With these changes (and bug 1278135), the clang plugin no longer asserts when I run it in an assertions-enabled build!
Attachment #8760103 - Flags: review?(ehsan)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/744db8f3ad0c Fix assertion errors in the clang plugin, r=ehsan
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.