Closed Bug 123205 Opened 23 years ago Closed 15 years ago

loading Mail/News 3-pane sidebar grippy causes sidebar to display all weird

Categories

(SeaMonkey :: Sidebar, defect)

x86
Windows 2000
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: mozbugz, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [adt3])

Attachments

(6 files)

Loading of the mail/news sidebar in 3-pane view has quite a problem with
displaying  the sidebar correctly.  I see a reproduceable method here, I think
we should load sidebar content, or have sidebar disabled with no grippy in view,
so if you hit F9 it should load sidebar, or be initalized in regards to bug 117130.

see two bugs: bug 117130 about sidebar delay in mail/news, two: bug 121215
mail/news sidebar is empty at startup.

steps that are reproduceable to get sidebar to display correctly on startup of
mail/news again after closing mozilla .

1. first create a new profile.
2. open mail/news window
3. create a newgroup account if you like.
4. move the mail/news sidebar grippy up to middle of folder pane.
5. notice sidebar is not loaded initially.  this is problem #1: see screenshot 1.
6. hit F9, see grippy gets removed from folder pane, but dark sidebar area
remains, see screenshot 2.
7. hit F9 again, see sidebar content becomes available but starts at the point
of the grippy line that was removed: so here is one problem #2: see screenshot 3
8. now, move current grippy downward, but not all the way: towards bottom of
folder pane, observe new grippy line position:  sidebar content disappears below
old grippy line: problem #3: see screenshot 4
9. from new grippy line position: move grippy back up: problem #4: see screenshot  5
10. now hit F9 again to close sidebar & its content: see screenshot 6.
11. hit F9: so sidebar opens all the sidebar will work fine for rest of session
and subsequent sessions without the above problems.

Actually results: sidebar doesn't load content when moving grippy up, and then
doesn't display correctly, it appears to not understand the bottom and top of
the pane coordinates correctly.

Expected results: sidebar should be loaded, pending bug 117130 at first move of
the grippy up.. and work fine like browser & addressbook sidebar do.  Or do not
show grippy line at bottom of folder pane when initializing Mail/News 3-pane
window upon startup of new build/new profile.
Depends on: 117130
Attached image screenshot 1 —
Attached image screenshot 2 —
Attached image screenshot 3 —
Attached image screenshot 4 —
Attached image screenshot 5 —
Attached image screenshot 6 —
One last note, I actually see that sidebar is being re-initialized to the grippy
bar at the bottom and my steps to reproduce apply again after closing down
mozilla and starting up using build 2-2-08 w2k, I dont recall that this was the
case with the mail/news sidebar in builds from a fews days back.
Sure I had a bug on this.  Can't find it.  If I do find it I'll dupe this one in
favor of the older one.

Can anyone help by finding out between which two builds this cropped up?  Thanks.
Severity: normal → critical
Priority: -- → P1
Target Milestone: --- → mozilla0.9.9
Keywords: nsbeta1
*** Bug 54276 has been marked as a duplicate of this bug. ***
Samir,

I've been trying to see where this started, It appears to be fine in 0.9.4.1 and
was somewhere in between that and before 0.9.6 landed.  It'll take me awhile on
dialup to narrow it down further than 0.9.5 I also haven't tested yet here.
After reading bug 54276 comment #14, it appears 0.9.4 is broke, even though I
don't think 0.9.4.1 actually does have a problem.  I'll check that milestone
build again.
Dennis, 
Thanks for the info.  I didn't realize this defect was around for this long.
I guess netscape 6.2.1 avoids the issue by enabling the sidebar content to load
 and the grippy line is in the middle in between the top and bottom of the
folder pane.  
*** Bug 125277 has been marked as a duplicate of this bug. ***
Samir,

milestone build 0.9.5 is also exhibiting this behavior.  So I bet this was
modified on the 0.9.4.1 branch only.  I'll check to see if I can get bonsai to
spit out that branch then to see if anything was changed for this.
Samir,

here is some digging I did. Using bonsai to query the 0.9.4 branch: 0.9.4.1
didn't come up with anything and the very very long 0.9.4 bonsai query:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_0_9_4_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=all&mindate=&maxdate=&cvsroot=%2Fcvsroot

I was able to find these bugs that relates to this problem:

--------
9/18/01 17:09

Mscott's: bug 99491, messenger.xul v1.220.2.1 & Mail3PaneVertLayout.xul v1.67.2.1

--------
09/21/01 17:29: 

Hyatt's: bug 94180 about grippy, messenger.xul v1.220.2.2


--------
09/25/01 13:44

Andrew's bug 94794 for fixing mac grippy problems: mac/global.css v1.27.24.1 &
classicBindings.xml v1.30.2.1

--------
09/26/2001 14:37

Seth's bug 94180 fixed again with addressbook grippy fix: addressbook.xul
v1.126.2.1 & Mail3PaneVertLayout.xul v1.67.2.2

--------

thats about all I could come up with for now, hopefully its just something never
made it to the trunk :)



I tried finding these on the trunk, the bonsai query from 09/17/01 to 09/26/01
and it spits out 150,000+ lines of changes to the code, good news is moz didn't
crash and handled it on dialup, bad news: nearly went blind trying to find these
fixes.. which the page comes in at probably 100+ pages.. so don't try this
unless you wanna suffer that.. 

I found these files on the trunk during the same time frame for the bugs
mentioned above:

messenger.xul    ---------------       v1.222 & v1.221
global.css                             v1.30
classicBindings.xml    ------------    v1.33
mail3PaneWindowVertLayout.xul          v1.69
addressbook.xul      -----------       v1.129

Now, if we can get our hands on these builds 9/18 9/22 9/26 & 9/27.. 

I'm guessing, cc the ns crew here.. :)
Samir, I just took a look at the latest nightly here: Addressbook's sidebar will
load open like the netscape 6.2.1 mail/news sidebar load's open and not have any
of these grippy & display problems.  So I'm guess that maybe since addressbook
puts the sidebar in folder pane like mail/news this code should be similar.
*** Bug 126385 has been marked as a duplicate of this bug. ***
note: seth just changed the addressbook sidebar to not load initally on a new
profile, build 2-19-15, bug 124430.  There is not a grippy showing in the
addressbook now, you have to hit F9, something that be necessary here or bug 117130.
Target Milestone: mozilla0.9.9 → mozilla1.0

*** This bug has been marked as a duplicate of 121215 ***
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → DUPLICATE
verified.
Status: RESOLVED → VERIFIED
Samir, reopening.

bug 121215 didn't fix this, doesn't sidebar content suppose to show up too,
before we move the grippy?  All I get is the change to the sidebar grippy
displayed on a new profile, but not its content.  I still see just perhaps
weirder painting issues than before 121215 went in.. I think we should copy the
addressbook's XUL, or JS on this one.. 
Status: VERIFIED → REOPENED
Resolution: DUPLICATE → ---
Dennis, 
Please try this with a new profile.  The sidebar is supposed to be off by
default in mailnews.  If you see problems with the grippy please report back
here with detailed steps to reproduce.  Thanks.
Target Milestone: mozilla1.0 → mozilla1.2alpha
as this bug is really about using the sidebar the first time Mail/News ever
comes up.. 

I think the trick is a fix like for bug 127113.. or bug 119975 as Mail/News
sidebar still blank on a new profile.. I have to hit F9 to get the content to
show up..
nsbeta1+ per Nav triage team, Nav3, ->1.0
Keywords: nsbeta1nsbeta1+
Whiteboard: [nav3]
Target Milestone: mozilla1.2alpha → mozilla1.0
This bug is really driving me up the wall..  this is the breakdown of the way I
see this bug exist.. and how it should be fixed.


screenshots:
------------

-I can attach new screen shots if you like:  some of the old ones will work on
this.. I have screen #'s for reference if you want them attached.  

when refering to these screen #'s see already uploaded files here.. 


screen #4 behavior: is same as screenshot 1 attachment 67629 [details].
screen #5: is the same as screenshot 2 attachment 67630 [details].
screen #6: is the similar as weirded problem as in screenshot 3 attachment 67631 [details].
screen #7: is the same as screenshot 4 attachment 67632 [details], but New* painting issue
starts here, mirrors browser.


I can upload the new screenshots with the weird painting issue too.


The New* painting issue vs the Old* painting issue:
---------------------------------------------------

Old* - see Mozilla current behavior weirdness from moving the grippy up and
down, etc for Old painting issue

New* - I think comes from the latest changes to the hbox to vbox code in the XUL
file.  (where if you move the browser window up so it becomes smaller you will
see this weirdness of sidebar content over the statusbar icons & so forth)


Definitions (wording I used before):
------------------------------------

*Content  - I previously refered to is what is really the sum of all the
viewable: Panels, + buttons, wording, not an individual Panel's Content.




ok, breaking this down to the bone: 
-----------------------------------

I'm on W2K, using NS6.2.2, and Mozilla 3.22.03 win32-installer.exe bits.. new
build directory/new profile.



Netscape 6.2.2 Behavior
-----------------------

1) Open Mail News.. see screen #1 - sidebar is halfway + panels show with
content.  Account Wizard is open for first dialog.



Mozilla 3-22-03 build Current Behavior: "Default User" Profile name/New
directory on very first use of Mail/News after installing the build.
------------------------------------------------------------------------------

1) Open Mail News.. see screen #1 - grippy is down. - Account Wizard comes up.
2) click cancel - see screen #2
3) click Exit - see screen #3
4) Move grippy Up - see screen #4 - there are *no* panels and wording, and
buttons.. 
5) Hit F9 - see screen #5 - grippy disappears, blank grey area.
6) Hit F9 again - see screen #6 - panels show up, but start above where grippy
line was/grey to white line is

7) move grippy down some - see screen #7 - at this point there is a New*
painting issue..that mirrors the browser sidebar.

8) move grippy down to bottom - see screen #8 - grippy should be back to status line
9) now move grippy up - see screen #9 - there are now panels, wording, and
buttons.. 


you can hit [X] or F9, or View > Sidebar all you want now and you see the
sidebar or not without problems.




4-pane view also is blank, but works like the browser sidebar does (without a
split pane).




Current Mozilla 3-22-03 Addressbook on first use ever:
------------------------------------------------------

Seth changed Addressbook so its grippy is no longer in view.


The Issues: AB vs Mail/News displaying the grippy/or not displaying the grippy
first.
-------------------------------------------------------------------------------------

Addressbook *doesn't* show the grippy on screen #1 - so no problem, you just hit
F9 or view -> sidebar.

Mail/News *does* - see Mozilla Current behavior screen #1.



The Questions for clarification so we are on the same page:
-----------------------------------------------------------

what exactly is the definition of the wording for "the sidebar is supposed to be
off by
default in mailnews"?

Is it suppose to be like Mail/News behavior screen #1 - grippy exists in view,
but at bottom of pane?

or 

like Seth's change to Address Book Behavior - screen #1 - no grippy exists in
view at all?


Samir, if you can elaborate as to what exactly is the *wanted behavior we want
to do also, that would be 

helpful as well.. :)



if you agree with Addressbook:
------------------------------

then I think you can back out part of the sidebar XUL change that causes the
New* painting issue, and painting 

problems will go away with that.  We dont have to worry about the OLD* painting
issues from Mozilla current 

behavior steps.. and we can just not have grippy in view/ ( like un-sidebar
checkedmarked)

- (this is the comment I made about copying Addressbook.XUL or JS behavior)



if you agree with Mail/News:
----------------------------

we need to fix the current behavior, backout part of the new changes which also
causes New* painting issues: 

then see what should be like my Expected results


Expected Result from a patch: It should work like this:
-------------------------------------------------------

1) Open Mail News.. see screen #1 - grippy is Up. (or down not sure which it
should be exactly, going off of 

netscape here)    -this would be my definition of the sidebar is not loaded
unlike NS6.2.2 behavior.

2) click cancel
3) click Exit
4) Move grippy Up - see screen #4 - there should be panels and wording, and
buttons.. etc -normal sidebar.


How to fix this problem, I guess: 
---------------------------------

again, just suggesting a trick like the first F9 bug change like bug 116094. or
bug 119975.


-Dennis
 
Samir,

I was wondering if this dates back to 0.6 Milestone.. or even 0.9.2 branch.. Its
hard to say, I've tried to give the JS Debugger a look, but I'm at a loss for
how it works, as continue, step thru and step over doesn't work.. There is not
much help, and code tracing is no where near the level of Borland Turbo C, C++
IDE's.. 

so I'm not even sure where to start.  But I'm just going to start searching the
older checkins to see if I can find more changes.
I just realized I can download the older milestones off the moz ftp server.. so
I'll grab as many as I can and test out new profiles for this problem.
Samir, Trudelle, Olga, I've found a breakthru here.. for this and bug 121215.

ok, it appears working, but note: Sidebar grippy height = half of the folder
pane. This stems from 0.6 milestone.  0.8 and 0.9 have the same functionality. 
There are panels there with content and sidebar is 'on'.


This behavior changed to grippy at the bottom of folder pane, and no panels are
shown when moving grippy up.. which is what we still see today: broken in 0.9.1
milestone.


I've been looking at checkins for 3/26/2001 to 5/7/2001 I think it started
earlier that 3/26  but I could get Mozilla to spit out the whole checkin list on
dialup.. so I've resorted to LXR and search for sidebar.. and I'm thinking first
the changes happened from bug 60071, just before 0.9.1 milestone.  

Next maybe's are bug 70746 and bug 72923 from LXR changes around 0.9 to 0.9.1
milestone.
Finally understand that I have to Stop the debugger before opening a window such
as Mail/News.. so I can step thru the lines of code, so I'm going to try to see
if I can find something here.
Please update this bug with an [adt1] - [adt3] impact rating (or take it off the
list if it doesn't even rate adt3.)  Thanks!
converting nav3->adt3
Whiteboard: [nav3] → [adt3]
Mass moving nsbeta1+/adt3 bugs assigned to Navigator team engineers out to
target milestone 1.0.1.  Please confine your attentions to driving down our list
of TM 1.0 bugs for beta.  Better to help, debug, or test one of them than fix
one of these.
Target Milestone: mozilla1.0 → mozilla1.0.1
Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email adt@netscape.com.  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.
Keywords: nsbeta1-
Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email adt@netscape.com.  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.
Keywords: nsbeta1+
Samir, 

You know what is really weird, somehow, here is my guess.  The Netscape 7PR1,
doesn't suffer this problem.  Only the mozilla branch.  When you fixed up bug
121215, did you fix the commercial branch at that time and not the trunk?  Or
does it suffer from a seperate problem?
*** Bug 89882 has been marked as a duplicate of this bug. ***
*** Bug 144370 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
Assignee: samir_bugzilla → nobody
Status: REOPENED → NEW
Priority: P1 → --
QA Contact: sujay → sidebar
Target Milestone: mozilla1.0.1 → ---
We don't have a sidebar in mailnews 3pane window these days.
Status: NEW → RESOLVED
Closed: 22 years ago15 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: