1232064 - If the user deletes an app and the last Pinned page at the same time, the homescreen will be stuck in edit mode and unable to launch apps

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat_double-delete.txt

Description:
If the user long presses a Pinned Page to select it in edit mode, then long presses an app, they are able to have both the Page and the app selected at the same time. If they choose to Delete, it will delete both the page and the app at the same time.

Furthermore, if the last Pinned Page was deleted this way, the homescreen will appear to leave edit mode, but will still treat apps as if they are in edit mode, but without the edit UI.  This prevents the user from launching, editing, or deleting any apps from the homescreen. They are only able to rearrange apps.

Notes:
-On the 2.6 branch, the user is able to resolve this issue by entering task manager, or locking the device.  These workarounds do not work on the 2.5 branch.
-The user may need to stick the homescreen between both panels (bug 1232048 and bug 1231846) in order to enter edit mode with both the Pages and Apps panels.

Repro Steps:
1) Update a Aries to 20151211115227
2) Pin an Page to the homescreen
3) Return to the homescreen and pan halfway between the homescreen panels
4) Long press the Pinned Page to select it in edit mode.
5) Long press a removable app or Pinned Site to select it in edit mode as well.
6) Tap the trash (delete) icon and confirm the deletion.
7) Attempt to launch the Browser app from the homescreen.

Actual:
The user is able to enter edit mode in both the Page and App panels, delete two items at once, and is then prevented from launching an app from the homescreen.

Expected:
The user is not able to enter edit mode for both the Page and App panels at the same time. The user cannot delete more than one item from the homescreen at a time. The user is always able to launch apps from the homescreen.

Environmental Variables:
Device: Aries 2.6
Build ID: 20151211115227
Gaia: d886e152b42e557db612470d3417fe2947cbdeee
Gecko: 754b4805a65cab4f3aca99899227acc44ba4fb20
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Repro frequency: 10/10
See attached: Video (URL), Logcat

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on the latest Flame Nightly 2.6 and 2.5 builds.
The user is not able to enter edit mode for both the Page and App panels at the same time. The user cannot delete more than one item from the homescreen at a time. The user is always able to launch apps from the homescreen.
Note: The Task Manager and Screen Lock workarounds are not available on the 2.5 build.

Environmental Variables:
Device: Flame 2.6
BuildID: 20151211030233
Gaia: d886e152b42e557db612470d3417fe2947cbdeee
Gecko: 754b4805a65cab4f3aca99899227acc44ba4fb20
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Environmental Variables:
Device: Flame 2.5
BuildID: 20151211164817
Gaia: 062e0fa48c1b5d5156f6911a5a4519128fac3231
Gecko: ded0306e0d78528cdcb237c8b05543390f10ec96
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

*****************************************

The New Homescreen is not implemented in the 2.2 branch.

Comment 2

[Chris Lord [:cwiiis]]

(In reply to Martin Shuman [:Marty] from comment #0)
> -The user may need to stick the homescreen between both panels (bug 1232048
> and bug 1231846) in order to enter edit mode with both the Pages and Apps
> panels.

Well, there's no 'may' about this, the user definitely needs to do this to get this to happen :) This code could do with being more robust though, this is an easy check to add / unit-test.