1232144 - Public holiday calendar for England 2015-2020

Status: RESOLVED FIXED

(Calendar :: Website, defect)

Description

[Steve Randall]

Attachment: EnglandHolidays.ics

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.80 Safari/537.36

Comment 1

[Stefan Sitter [:ssitter]]

There is already another calendar waiting for upload in Bug 1120403. But based on its description it only includes calendar information up to 2016.

Comment 2

[Steve Randall]

The one I attached includes up to 2020 - I've double checked. :-)

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Could you merge the information from both calendars? It seems the other one contains more/other holidays, for example St. Patrick's Day.

Comment 5

[Steve Randall]

Did you want me to add more information to the calendar - e.g. patron saint days, etc.?

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Steve, there is another calendar in bug 1120403 that contains some more days aside from this one. I'd appreciate one that contains days from both calendars, if you agree the additional days make sense.

Comment 7

[Steve Randall]

(In reply to Philipp Kewisch [:Fallen] from comment #6)
> Steve, there is another calendar in bug 1120403 that contains some more days
> aside from this one. I'd appreciate one that contains days from both
> calendars, if you agree the additional days make sense.

I've sent the new, amended calendar to your email as I can see no way of attaching it to this bug.

Comment 8

[Steve Randall]

Is it OK? Let me know if you want any further amendments.

Comment 9

[[:MakeMyDay]]

Steve, you can attach the calendar using the "Add an attachment" link above (below the header section and the existing attachment)

Comment 10

[Brian Wray]

This bug is not an exact duplicate of my bug 1120403.
That file contains public holidays for all countries that make up the United Kingdom (England & Wales, Scotland, and Northern Ireland (Ulster)) as they are not always the same (St Patrick's Day is an Irish holiday for example).  As noted, the file attached to that bug only covers up to 2016 as that was the data available to me at the time.

This bug only updates the English public holidays (current published file is here https://www.mozilla.org/media/caldata/EnglishHolidays.ics, covering up to 2015)

Comment 11

[Brian Wray]

Attachment: ICS file for all UK Public Holidays 2010-2020

This file is intended to replace Mozilla website holiday file https://www.mozilla.org/media/caldata/UKHolidays.ics

It has been updated to add public holidays from 2016-2020 and to bring some descriptions into line with current practice.

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to Brian Wray from comment #11)
> Created attachment 8728389 [details]
> ICS file for all UK Public Holidays 2010-2020
So this is a replacement that contains the merged holidays? Great! Are you comfortable with making github pull requests? If so, can you make a pull request similar to https://github.com/mozilla/bedrock/pull/3734 that updates the .ics file and the calendar metadata in media/caldata/calendars.json ?

Please needinfo me if not, then I'll take care soon.

Comment 13

[Brian Wray]

(In reply to Philipp Kewisch [:Fallen] from comment #12)
> So this is a replacement that contains the merged holidays? Great! Are you
> comfortable with making github pull requests? If so, can you make a pull
> request similar to https://github.com/mozilla/bedrock/pull/3734 that updates
> the .ics file and the calendar metadata in media/caldata/calendars.json ?

Apologies for delay responding. I am not a member of, or familiar with, github, so I think that I will have to leave this one to you on this occasion, sorry.

As noted in comment #10 there are two overlapping files in the media/caldata area, EnglishHolidays.ics (England is one of the four countries that make up the United Kingdom) and UKHolidays.ics. It is this latter file which I (created originally and) have updated at comment #11.

I leave it to those better qualified as to what is now to be done with EnglishHolidays.ics (the one in media/caldata only ran to 2015, so is obsolete). The original attachment provided by the reporter of this bug could be used to update it, but without equivalent files for Scotland and Northern Ireland (Welsh holidays are currently the same as English), I consider that only maintaining a whole-of-UK file is more use and less confusing.

Comment 14

[Magnus Melin [:mkmelin]]

Updated the UK calendar from comment 11, and removed the EnglishHolidays.ics - it was rather incomplete (or at least confusing wrt. the UK one)
https://github.com/thundernest/thunderbird-website/commit/f502e7422a03ccdca0bc6feab507918f725f914d
https://github.com/thundernest/thunderbird-website/commit/c42e609195359ce15c26fb95c67856f1ad4da9f5