1232264 - Make the SharedArrayBuffer constructor throw if invoked without 'new'

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[André Bargull [:anba]]

Similar to bug 1214936: Calling `SharedArrayBuffer` without `new` should throw a TypeError [1].

Test case:
---
SharedArrayBuffer(new SharedArrayBuffer(1))
---

Expected: Throws TypeError
Actual: Returns input SharedArrayBuffer object


[1] http://lars-t-hansen.github.io/ecmascript_sharedmem/shmem.html#StructuredData.SharedArrayBuffer.constructor.withLength

Comment 1

[Lars T Hansen [:lth]]

My bad.

Comment 2

[Lars T Hansen [:lth]]

Attachment: SharedArrayBuffer is only a constructor

Comment 3

[Tooru Fujisawa [:arai]]

Comment on attachment 8698421 [details] [diff] [review]
SharedArrayBuffer is only a constructor

Review of attachment 8698421 [details] [diff] [review]:
-----------------------------------------------------------------

:)

Comment 4

[Lars T Hansen [:lth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ebd9b147a2a49abe0a9b4144c4d8b1d3c9193ce
Bug 1232264 - SharedArrayBuffer is only a constructor.  r=arai

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4ebd9b147a2a

Comment 6

[Kohei Yoshino [:kohei]]

This may not require dev docs since SharedArrayBuffer is only available on Nightly so far...

Comment 7

[Lars T Hansen [:lth]]

kohei, don't know what the rules are for that, but SharedArrayBuffer will ride the trains (behind a pref) from FF46, see bug 1225406 (which btw is flagged dev-doc-needed).

Comment 8

[Florian Scholz (Open Web Docs)]

Putting back ddn. I am going to work on SAB docs soon and this is a nice reminder to document this behavior.

Comment 9

[Florian Scholz (Open Web Docs)]

Added a note here
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer#Constructing_is_required_with_new_operator