Closed
Bug 1232271
Opened 9 years ago
Closed 9 years ago
[Static Analysis][Uninitialized scalar variable] Function PaintedLayerData from FrameLayerBuilder.cpp
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1324699)
Attachments
(1 file)
|
906 bytes,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
The Static Analysis tool Coverity added scalar mSolidColor member of PaintedLayerData is not assigned value in the constructor. Although this is not an issue since the usage of mSolidColor depends on the validity of mIsSolidColorInVisibleRegion that is set to false, can we add this scalar to the costructor in order to silence the analyzer?
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8697976 -
Flags: review?(dbaron)
Attachment #8697976 -
Flags: review?(dbaron) → review?(matt.woodrow)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8697976 [details] [diff] [review] Bug 1232271.diff Review of attachment 8697976 [details] [diff] [review]: ----------------------------------------------------------------- Sure, why not.
Attachment #8697976 -
Flags: review?(matt.woodrow) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 3•9 years ago
|
||
Hi, this failed to apply: adding 1232271 to series file renamed 1232271 -> Bug_1232271.diff applying Bug_1232271.diff patching file layout/base/FrameLayerBuilder.cpp Hunk #1 FAILED at 405 1 out of 1 hunks FAILED -- saving rejects to file layout/base/FrameLayerBuilder.cpp.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and qrefresh Bug_1232271.diff
Flags: needinfo?(bogdan.postelnicu)
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•9 years ago
|
||
As per the offline discussion this is not a problem with the patch.
Flags: needinfo?(bogdan.postelnicu)
|
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3640bc5dacc7
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•