Implement test_home_button.py and test_home_button_in_edit_mode.py as an Integration test in JavaScript

RESOLVED FIXED in 2.6 S3 - 12/18

Status

Firefox OS
Gaia::Homescreen
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jlorenzo, Assigned: gmarty)

Tracking

unspecified
2.6 S3 - 12/18
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gip-to-gij][systemsfe])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Bug 1195364 was started as a Python test, but pressing the home button like we do in this test is actually like we should do in an integration test.

I couldn't find an equivalent of [1] in the Gij suite. 

[1] https://github.com/mozilla-b2g/gaia/pull/31423/files#diff-9f1ebdc2a3cc811a6deb601c9ba24d27
(Reporter)

Comment 1

3 years ago
test_home_button_in_edit_mode.py[1] can also be added along the same test file.

[1] https://github.com/mozilla-b2g/gaia/pull/31423/files#diff-a2d567c9ffb6d3ba89a67dead18f1a3f
Summary: Implement test_home_button.py as an Integration test in JavaScript → Implement test_home_button.py and test_home_button_in_edit_mode.py as an Integration test in JavaScript
Guillaume, can you help out here?
Flags: needinfo?(gmarty)
Whiteboard: [gip-to-gij] → [gip-to-gij][systemsfe]
(Assignee)

Updated

3 years ago
Assignee: nobody → gmarty
Flags: needinfo?(gmarty)
Created attachment 8699518 [details] [review]
[gaia] gmarty:Bug-1232280-homescreen-home-button-gip-to-gij > mozilla-b2g:master

Comment 4

3 years ago
Comment on attachment 8699518 [details] [review]
[gaia] gmarty:Bug-1232280-homescreen-home-button-gip-to-gij > mozilla-b2g:master

Pre-emptive r+, lgtm.
Attachment #8699518 - Flags: review+
(Assignee)

Comment 5

3 years ago
Ah ah! Amazing Chris, so fast. Thanks a lot!
Let's see what Gaia Try thinks of it now.
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/37210d8e5376b514bef74048cc49043fc88d7954
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S3 - 12/18
You need to log in before you can comment on or make changes to this bug.