1232328 - HAR Viewer redeclares functions; not ES6 compatible

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Patrick McManus [:mcmanus]]

http://www.softwareishard.com/har/viewer/ renders as blank page in nightly 45 linux x64 Built from https://hg.mozilla.org/mozilla-central/rev/99137d6d4061f408ae0869122649d8bdf489cc30

looks fine on current 44

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

WFM on https://hg.mozilla.org/mozilla-central/rev/9aa2dae27ae5bb4e0f9db2945a87068c4df073be

Comment 2

[Loic]

Regressed by bug 1071646:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d55129069a1f56f63573282911ad2dac17d6e7b1&tochange=ffd21df83fee3ee19c894df4f3b55e58c9f25e58

Comment 3

[Tom S [:evilpie]]

Reduce:
with ({}) {
    function Pie() {}
    var Pie = "test";
}

Comment 4

[Shu-yu Guo [:shu]]

For now, block-scoped functions and Annex B semantics have been backed out for breaking the web (Google Inbox being most prominent): https://hg.mozilla.org/integration/mozilla-inbound/rev/d2bec6ed7b30

Keeping NI open so I can investigate for when we re-land.

Comment 5

[Shu-yu Guo [:shu]]

Actually let me reopen and NI Jan, this is a bug in his code.

Jan, |function Pie() {}| and |var Pie = ...| in HAR Viewer in webapp/scripts/pageState.js break in ES6 because functions are block-scoped. Could you fix?

I would've filed an issue on Google Code but there was some warning about how the project is archived and read-only.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the note!

The project is on github.com

Here is the related issue + patch:
https://github.com/janodvarko/harviewer/issues/50

How can I test this?
If I understand the breaking changes have been backed out?

Honza

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Ah, forgot to note, the patch is in the repo (master), but not yet released (online) on the site.

Honza

Comment 8

[Shu-yu Guo [:shu]]

We can sit on it for now. I'll try to reland the breaking changes in a week or two when Inbox gets fixed. Then we can verify the patch fixes the problem.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Not tracking for 45 as we moved this change to 46.

Comment 10

[Doug Turner (:dougt)]

inbox appears to be fixed, can we proceed?

Comment 11

[Shu-yu Guo [:shu]]

Google Inbox has been fixed and functions-in-block has relanded. If :Honza has merged his tip fix we can close.

Comment 12

[Naveed Ihsanullah [:naveed]]

Thanks Shu. Honza let us know how it goes.

Comment 13

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yes, fixed and the online version is updated
http://janodvarko.cz/har/viewer/

Honza