Closed Bug 1232331 Opened 10 years ago Closed 10 years ago

Factor out test logic from UI classes (about window, software update dialog) to update testcase

Categories

(Testing :: Firefox UI Tests, defect)

Product:
Testing
Component:
Firefox UI Tests
Version:
45 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox43 fixed, firefox44 fixed, firefox45 fixed, firefox46 fixed, firefox-esr38 wontfix)

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox43 --- fixed
firefox44 --- fixed
firefox45 --- fixed
firefox46 --- fixed
firefox-esr38 --- wontfix

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(2 files)

Github PR
52 bytes, text/x-github-pull-request
impossibus
: review+
Details | Review
Github PR (bustage fix for test_about_window)
52 bytes, text/x-github-pull-request
whimboo
: review+
Details | Review
Right now we have some assertions which have been placed e.g. in the AboutWindow UI class. Those have to be moved out into the update testcase class as helper methods.
This affects all branches including 46.0 which I currently cannot set due to missing status flags. Will do it once bug 1232805 has been fixed.
status-firefox43: --- → affected
status-firefox44: --- → affected
status-firefox-esr38: --- → wontfix
Summary: Factor out assertions from UI classes to update testcase → Factor out test logic from UI classes (about window, software update dialog) to update testcase
Attached file Github PR —
Lots of refactoring. Not sure why we put that many test logic in ui libraries. It should be all cleared up now for the about window and the old software update dialog. Please see the individual commits for partial changes.
Attachment #8698660 - Flags: review?(mjzffr)
Merged PR to mozilla-central: https://github.com/mozilla/firefox-ui-tests/commit/4afd18763bdcde5f8b1c241e5b9a83048d99e15d I will backport to the other branches if all stays green the next days.
status-firefox46: affected → fixed
Target Milestone: --- → Firefox 46
Blocks: 1234495
The backport of the patch to beta and release was not correct. See the regression from bug 1234495. I have to fix the remaining failures.
Status: RESOLVED → REOPENED
status-firefox43: fixed → affected
status-firefox44: fixed → affected
Resolution: FIXED → ---
Tiny patch which fixes the bustage in the about window test. I hope its ok to get it landed right away to clear the bustage for beta and release.
Attachment #8700979 - Flags: review+
Depends on: 1236569
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: