Closed Bug 1232346 Opened 4 years ago Closed 4 years ago

crash in mozilla::WebGLContext::BindFakeBlack

Categories

(Core :: Canvas: WebGL, defect, minor)

x86_64
macOS
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- unaffected
firefox46 --- fixed

People

(Reporter: jujjyl, Assigned: jgilbert)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-61018c40-8046-410f-9556-182422151214.
=============================================================

STR:

1. Visit http://beta.unity3d.com/jonas/DT2/
2. Once the levels load, click Play on the level on the left and after the level load finishes, Firefox will crash.
This looks like a very new regression. Current trunk suffers, but e.g. mozilla-central from 2015-12-06 is good (tested with mozregression).
Tried to run mozregression for this, but I noticed that the crash does not occur 100% of the runs, which led me to faulty bisect results. Currently the ftp is failing to serve me builds to try another bisection run. I take back comment 1 that 2015-12-06 would be good, believe it is actually bad but not 100% crashing. Mozilla-central from 2015-11-29 is now the earliest that I have seen this to crash with.
Bisecting again with multiple runs for confidence (seems to crash about 80% of the time in bad revisions) points to this as the offending commit: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=390cb35d92453aeccb0acf85dc113616f1006be1&tochange=7d1c223f397cdbcf494a4ef7ff7e56a5100b14c2

Jeff, could you take a peek to see if you can reproduce?
Flags: needinfo?(jgilbert)
I swear I fixed this bug already, but I can't find where I fixed it.
Assignee: nobody → jgilbert
Flags: needinfo?(jgilbert)
Attachment #8698290 - Flags: review?(dglastonbury)
See Also: → 1229944
Bug 1229944 patch 0001 is similar to this fix, and is what I was remembering.
Depends on: webgl-tex-refactor
Attachment #8698290 - Flags: review?(dglastonbury) → review+
https://hg.mozilla.org/mozilla-central/rev/5c539183aea4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
When bug 1229944 lands on 45, 45 will be unaffected.
Severity: critical → minor
You need to log in before you can comment on or make changes to this bug.