Closed
Bug 1232446
Opened 10 years ago
Closed 10 years ago
Re-enable method calls in SelfHosted code, asserting they are not calling content functions.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: efaust, Assigned: efaust)
Details
Attachments
(1 file)
|
9.38 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
The two changes to TypedObject.js are silly. The function in question is defined non-configurable non-writable. It's "self-hosting safe", but it looks for all the world like a content function.
Attachment #8698177 -
Flags: review?(till)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8698177 [details] [diff] [review]
SHmethodReenable.patch
Review of attachment 8698177 [details] [diff] [review]:
-----------------------------------------------------------------
This is very nice! I'm not even all that offended by the TypedObject.js changed, honestly.
Attachment #8698177 -
Flags: review?(till) → review+
|
||
Comment 3•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•