Closed Bug 1232446 Opened 6 years ago Closed 6 years ago

Re-enable method calls in SelfHosted code, asserting they are not calling content functions.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: efaust, Assigned: efaust)

Details

Attachments

(1 file)

The two changes to TypedObject.js are silly. The function in question is defined non-configurable non-writable. It's "self-hosting safe", but it looks for all the world like a content function.
Attachment #8698177 - Flags: review?(till)
Comment on attachment 8698177 [details] [diff] [review]
SHmethodReenable.patch

Review of attachment 8698177 [details] [diff] [review]:
-----------------------------------------------------------------

This is very nice! I'm not even all that offended by the TypedObject.js changed, honestly.
Attachment #8698177 - Flags: review?(till) → review+
https://hg.mozilla.org/mozilla-central/rev/e2d7e9400d74
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.