1232462 - WebGL rope demo doesn't work

Status: VERIFIED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jim Blandy :jimb]

Attachment: Console output

When I visit the given URL, I see a mostly blank light blue page with an FPS meter in the upper left and a bit of text at the top, but no rope. I've attached the output the page writes to the web console.

Comment 1

[Jamie Nicol [:jnicol]]

Works in firefox 43 but not nightly.

Also does not work in chromium 47.0.2526.73.

My guess would be an ANGLE bug, or as the console output says a bug in the shader which a newer ANGLE version is more strict about.

Comment 2

[Jamie Nicol [:jnicol]]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0495c1a481af957371269cb73cd335ba6b08cf66&tochange=ebadedcd40109681a4ce6748edab19313c9db363

Comment 4

[Jeff Muizelaar [:jrmuizel]]

I can't seem to reproduce this locally.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

[Tracking Requested - why for this release]: Web content regression.

Comment 6

[Jamie Nicol [:jnicol]]

According to bug 1233074 it affects linux and not windows, so believably not OS X either. I can reproduce on ubuntu.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

I'm able to reproduce this now. It's caused by a restriction added to glsl 1.3 that disallows sampler arrays indexed with non-constant expressions. I'm not yet sure what the best route to fix this is.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Attachment: Only ask for a higher version of GLSL when using WebGL2

This fixes the situation for now. I'm going to try to work out what should actually be happening here with ANGLE.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Here's the corresponding Chrome bug:
https://code.google.com/p/chromium/issues/detail?id=569907

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9fda66262ca8

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9fda66262ca8

Comment 12

[Petruta Horea [:phorea]]

Verified as fixed using Nightly 46.0a1 2015-12-18 using the both demos under Ubuntu 14.04 x86.

Aurora 45.0a2 2015-12-18 is still affected.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Jeff, could you fill the uplift request to aurora/45? Thanks

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8699171 [details] [diff] [review]
Only ask for a higher version of GLSL when using WebGL2

Approval Request Comment
[Feature/regressing bug #]: bug 1207288
[User impact if declined]: Some broken WebGL
[Describe test coverage new/current, TreeHerder]: Has been on central a while
[Risks and why]: Very low risk. This basically reverts us to our previous behaviour except when using WebGL2

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8699171 [details] [diff] [review]
Only ask for a higher version of GLSL when using WebGL2

Thanks

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5900cd9ccb59

Comment 17

[Petruta Horea [:phorea]]

Verified as fixed using latest Aurora 45.0a2 2016-01-11 under Ubuntu 15.04 64-bit.