Closed Bug 1232467 Opened 7 years ago Closed 7 years ago

Remove "Open links in Private browsing" setting from Nightly

Categories

(Firefox for Android Graveyard :: Settings and Preferences, defect)

35 Branch
defect
Not set
normal

Tracking

(firefox46 verified)

VERIFIED FIXED
Firefox 46
Tracking Status
firefox46 --- verified

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

This feature has been hanging out on Nightly for a long time and hasn't gone anywhere. Let's remove it for now until we can find time to implement a more nuanced approach.
Why hasn't it gone anywhere? What might a more nuanced approach be?
Flags: needinfo?(margaret.leibovic)
(In reply to Michael Comella (:mcomella) from comment #1)
> Why hasn't it gone anywhere? What might a more nuanced approach be?

It hasn't gone anywhere because it hasn't been a priority, so we haven't had time to work on it.

Bug 1205711 is what we should implement.
Flags: needinfo?(margaret.leibovic)
Assignee: nobody → margaret.leibovic
Comment on attachment 8699512 [details]
MozReview Request: Bug 1232467 - Remove "Open links in Private browsing" setting from Nightly. r=mcomella

https://reviewboard.mozilla.org/r/28263/#review25339

::: mobile/android/base/resources/xml/preferences_general.xml
(Diff revision 1)
> -                        android:title="@string/pref_open_external_urls_privately_title"

Should we be removing these strings too? Or is it a separate bug/commit so we can uplift?

::: toolkit/components/telemetry/Histograms.json:9278
(Diff revision 1)
> -  "FENNEC_OPEN_URLS_IN_PRIVATE": {
> +  "VIDEO_EME_DISABLED": {

I don't think we should be changing this Histogram value in this in this commit. r+ w/o this change.
Attachment #8699512 - Flags: review?(michael.l.comella) → review+
https://reviewboard.mozilla.org/r/28263/#review25343

::: mobile/android/base/resources/xml/preferences_general.xml
(Diff revision 1)
> -                        android:title="@string/pref_open_external_urls_privately_title"

Good call! I will remove these. We don't need to uplift this, so I can just do that here.

::: toolkit/components/telemetry/Histograms.json:9278
(Diff revision 1)
> -  "FENNEC_OPEN_URLS_IN_PRIVATE": {
> +  "VIDEO_EME_DISABLED": {

I think the diff formatting just makes this look fishy... all I did here was remove the FENNEC_OPEN_URLS_IN_PRIVATE histogram, which is expiring in 45.
(In reply to :Margaret Leibovic from comment #5)

> ::: toolkit/components/telemetry/Histograms.json:9278
> (Diff revision 1)
> > -  "FENNEC_OPEN_URLS_IN_PRIVATE": {
> > +  "VIDEO_EME_DISABLED": {
> 
> I think the diff formatting just makes this look fishy... all I did here was
> remove the FENNEC_OPEN_URLS_IN_PRIVATE histogram, which is expiring in 45.

Actually, I don't know what I was thinking here. I must have botched a rebase, which is why I ended up changing this probe. I'll fix this.
https://hg.mozilla.org/integration/fx-team/rev/9765236f55225dd74caee557f9ee3193467d4e6d
Bug 1232467 - Remove "Open links in Private browsing" setting from Nightly. r=mcomella
https://hg.mozilla.org/mozilla-central/rev/9765236f5522
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
"Open links in Private browsing" is no longer displayed in Settings:
Verified as fixed using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 46.0a1 (2015-12-22)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.