1232485 - TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/composition/test-attachment-reminder.js | test-attachment-reminder.js::test_manual_attachment_reminder

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[:aceman]

Still happens sometimes, e.g. https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=5106ef65c179

08:59:25     INFO -  SUMMARY-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_manual_attachment_reminder
08:59:25     INFO -    EXCEPTION: Timed out waiting for window open!
08:59:25     INFO -      at: utils.js line 447
08:59:25     INFO -         TimeoutError utils.js:447 13
08:59:25     INFO -         waitFor utils.js:485 1
08:59:25     INFO -         WindowWatcher_waitForWindowOpen test-window-helpers.js:247 1
08:59:25     INFO -         wait_for_new_window test-window-helpers.js:577 1
08:59:25     INFO -         wait_for_compose_window test-compose-helpers.js:218 21
08:59:25     INFO -         test_manual_attachment_reminder test-attachment-reminder.js:332 9
08:59:25     INFO -         Runner.prototype.wrapper frame.js:585 9
08:59:25     INFO -         Runner.prototype._runTestModule frame.js:655 9
08:59:25     INFO -         Runner.prototype.runTestModule frame.js:701 3
08:59:25     INFO -         Runner.prototype.runTestDirectory frame.js:525 7
08:59:25     INFO -         runTestDirectory frame.js:707 3
08:59:25     INFO -         Bridge.prototype._execFunction server.js:179 10
08:59:25     INFO -         Bridge.prototype.execFunction server.js:183 16
08:59:25     INFO -         Session.prototype.receive server.js:283 3
08:59:25     INFO -         AsyncRead.prototype.onDataAvailable server.js:88 3

Comment 1

[:aceman]

Attachment: patch

The pesky Edit button in sliding notification :) I hope it is the last one.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a55567c3df8e

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8698235 [details] [diff] [review]
patch

Review of attachment 8698235 [details] [diff] [review]:
-----------------------------------------------------------------

great! r=mkmelin

Comment 3

[:aceman]

https://hg.mozilla.org/comm-central/rev/9ea001f0573a

Comment 4

[aleth [:aleth]]

Comment on attachment 8698235 [details] [diff] [review]
patch

[Approval Request Comment]
User impact if declined: Test only, still seeing this occasionally on 45

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8698235 [details] [diff] [review]
patch

Kent, am I allowed to approve and land this?

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8698235 [details] [diff] [review]
patch

Silly me. That was landed on TB 46 which is now Aurora. So only TB 45 (beta) is needed.

Comment 7

[Jorg K (CEST = GMT+2)]

Beta (TB 45):
https://hg.mozilla.org/releases/comm-beta/rev/defcdd02f368