Closed
Bug 1232493
Opened 7 years ago
Closed 7 years ago
Version bump to 46 on mozilla-central broke several loop telemetry tests
Categories
(Hello (Loop) :: General, defect, P1)
Hello (Loop)
General
Tracking
(firefox46 fixed)
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: KWierso, Assigned: standard8)
Details
Attachments
(1 file)
3.71 KB,
patch
|
vladan
:
review+
RyanVM
:
feedback+
|
Details | Diff | Splinter Review |
Reporter | ||
Comment 1•7 years ago
|
||
I bumped several histogram expirations up to 47 in https://hg.mozilla.org/mozilla-central/rev/ae37fdb042c0
Updated•7 years ago
|
Whiteboard: [triage]
Comment 2•7 years ago
|
||
Looks there's more trouble on the horizon for Monday's merge when Gecko is bumped to 47: https://treeherder.mozilla.org/logviewer.html#?job_id=15710756&repo=try
Severity: normal → critical
Flags: needinfo?(standard8)
Updated•7 years ago
|
Rank: 5
Priority: -- → P1
Whiteboard: [triage]
Comment 3•7 years ago
|
||
We'd like to extend these measurements further: - LOOP_TWO_WAY_MEDIA_CONN_LENGTH_1 - LOOP_SHARING_ROOM_URL - LOOP_ROOM_CREATE - LOOP_ROOM_DELETE - LOOP_ROOM_SESSION_WITHCHAT I'm not sure what the process is for requesting that. We'd like to deprecate these measurements: - LOOP_ROOM_CONTEXT_ADD - LOOP_ROOM_CONTEXT_CLICK - LOOP_SHARING_STATE_CHANGE_1 Because of the release process for Hello, ideally we'd bump these measurements to 48 so we can remove them from the Hello code and import into mozilla-central before disabling the measurements entirely.
Assignee | ||
Comment 4•7 years ago
|
||
Per comment 3, we'd like to extend the expiry times for Loop's telemetry measurements. As the merges are on Monday, we're suggesting a bump of one version for the measurements we're going to depreacte. I'll get a bug or two filed on those in a few minutes. Pinging both Benjamin and Vladan for review - we only need one of you, but hoping to get one before Monday.
Attachment #8710988 -
Flags: review?(vladan.bugzilla)
Attachment #8710988 -
Flags: review?(benjamin)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → standard8
Flags: needinfo?(standard8)
Comment 5•7 years ago
|
||
Comment on attachment 8710988 [details] [diff] [review] Extend expiry time for Loop's telemetry hooks. Looks good on Try.
Attachment #8710988 -
Flags: feedback+
Comment 6•7 years ago
|
||
FYI, the version bump has hit m-c now, so this will start permafailing shortly.
Comment 7•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #6) > FYI, the version bump has hit m-c now, so this will start permafailing > shortly. Benjamin, vladan can we get this review soon ?
Updated•7 years ago
|
Attachment #8710988 -
Flags: review?(vladan.bugzilla) → review+
Assignee | ||
Updated•7 years ago
|
Attachment #8710988 -
Flags: review?(benjamin)
Assignee | ||
Comment 9•7 years ago
|
||
I filed bug 1242524 on removing the obsolete histograms.
Status: NEW → RESOLVED
Iteration: --- → 46.3 - Jan 25
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
status-firefox46:
--- → fixed
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•