1232535 - Clone the job type in the UI immediately after re-triggering

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, defect)

Description

[(no longer active)]

The current UX of re-triggering a job is very awkward.  There is no visual reaction to that, and then the job(s) suddenly appear out of nowhere at some point in the future!

It would be better to immediately show a new job type of the same type in a "loading" state where we wait for the actual async work to be finished before populating its data in the UI.

Comment 1

[William Lachance (:wlach)]

It isn't quite accurate to say there is no visual reaction, as we do (last I checked, anyway) show a notification when this action occurs.

That said, this sounds like a good idea to me. The implementation isn't trivial (we'd have to create a placeholder element inside the job model, then remove it as new results come in), but this might be a good task for someone to take on.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This might also be good to have for jobs requested via the "Add new jobs" menu item on each push. At the moment, if the request succeeds, there will eventually be a "Sch" job showing up near the bottom of the list of jobs for the push (which you'll never see if you've filtered the list of jobs down), and some indeterminate time after that, the jobs you actually requested will eventually show up where they're supposed to. (And if something went wrong somewhere in the requests, it'll just silently fail to show anything.)
If the jobs you requested would immediately (or at least, as soon as the network request for those jobs successfully responds) become "real" jobs in the UI, there'd be more feedback that things successfully happened. If at some point later, the requested jobs never actually materialize, we'd have to deal with that. (Transition the fake jobs into a 'canceled' state maybe? Would hitting retrigger on one of the fake jobs actually do something useful?)

Comment 4

[Cameron Dawson [:camd]]

Since this bug was written, we now have better notifications in the UI to indicate that job triggering succeeded or not.  You can also look in the Notifications History (the bell on the navbar) to see what you've requested to trigger, if that helps.

One of the issues with creating "placeholder" started jobs is that they wouldn't have IDs we could correlate with the real jobs, once they arrive as pending.  So we'd have to try to "figure out" if those new jobs we just got are the same as these placeholders.  We could use some fuzzy deductions, of course, but I fear those would be inherently inaccurate and confusing at times.

As such, we're going to close this as wontfix.