Closed Bug 1232580 Opened 5 years ago Closed 5 years ago
hg push review breaks my terminal
58 bytes, text/x-review-board-request
After calling `hg push review`, I lose the ability to read what I wrote on the terminal. stdout/stderr outputs from applications still work. Here's my prompt: PS1='\u \W \A\$ '
Your bug report lacks details to triage. We preferably need full console output. Also knowing the value of TERM, `hg config | grep term`, `hg config | grep color`, which version of Mercurial, and which terminal program you are using would be extremely helpful.
I'm using the MacOS X Terminal.app, version 2.6.1 $ hg config | grep term # Nothing $ hg config | grep color extensions.color= $ hg --version Mercurial Distributed SCM (version 3.6-rc+20-6474b64045fb) $ echo $TERM xterm-256color Full output: (running `hg push review`, then `ls`, then `echo "I have just called echo, can you see it?"`). david mc-probes 18:08$ hg push review pushing to ssh://reviewboard-hg.mozilla.org/gecko searching for changes no changes found submitting 1 changesets for review changeset: 273824:2e618e26e22c summary: Bug 1228020 - Removing about: pages from FX_PAGE_LOAD;r?dao review: https://reviewboard.mozilla.org/r/27971 review id: bz://1228020/Yoric review url: https://reviewboard.mozilla.org/r/27969 (draft) publish these review requests now (Yn)? n (visit review url to publish these review requests so others can see them) david mc-probes 21:44$ AUTHORS caps gradle moz.build startupcache Android.mk chrome gradle.properties mozglue storage CLOBBER client.mk gradlew mozilla-config.h.in testing GNUmakefile client.py hal netwerk toolkit LEGAL config image nsprpub tools LICENSE configure intl obj-x86_64-apple-darwin15.0.0 uriloader Makefile.in configure.in ipc obj-x86_64-apple-darwin15.0.0.noindex view README.txt db js other-licenses webapprt accessible devtools layout parser widget aclocal.m4 docshell mach probes xpcom addon-sdk dom media python xpfe b2g editor memory rdf xulrunner browser embedding mfbt security build extensions mobile services build.gradle gfx modules settings.gradle david mc-probes 21:45$ I have just called echo, can you see it? david mc-probes 21:45$
i'm unable to reproduce this using an almost identical setup. the only difference is i have hg 3.6.3 not 3.6-rc+20-6474b64045fb.
y u no iTerm2? You really want to use https://www.iterm2.com/. (That doesn't change the fact that this is a wonky bug.)
I still encounter the issue with 3.6.2.
Please follow up at https://bz.mercurial-scm.org/show_bug.cgi?id=5037, which is a similar bug report and hopefully the same underlying issue. Worth noting from the initial bug report that `hg push review` does perform a prompt, asking the user whether they want to publish what they just submitted.
https://bz.mercurial-scm.org/show_bug.cgi?id=5037#c13 and below say this is a MacPorts issue that can be worked around by `port install p27-readline`. Moving this to a mach bootstrap bug. Will submit patch shortly.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Component: MozReview → mach
Product: Developer Services → Core
I assume it's actually "py27-readline".
See https://trac.macports.org/ticket/48807. Without it, reading input can break terminals. Review commit: https://reviewboard.mozilla.org/r/30573/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30573/
Attachment #8707077 - Flags: review?(dteller)
Comment on attachment 8707077 [details] MozReview Request: Bug 1232580 - Install py27-readline on MacPorts; r?Yoric https://reviewboard.mozilla.org/r/30573/#review27485 Looks good to me.
Attachment #8707077 - Flags: review?(dteller) → review+
You need to log in before you can comment on or make changes to this bug.