Closed Bug 1232588 Opened 8 years ago Closed 8 years ago

wrap Media Storage panel into AMD module

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
tracking-b2g backlog

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(1 file)

We'd quickly wrap Media Storage panel to fit panel architecture, then refactor with Bug 973451 when we refocus on phone
Assignee: nobody → gasolin
Comment on attachment 8698336 [details] [review]
[gaia] gasolin:issue-1232588 > mozilla-b2g:master

Due to priority shift, I'd rather wrap rest of js into AMD panels even without refactor & adding unit tests. Test fine on device.
Attachment #8698336 - Flags: review?(yzenevich)
Blocks: 973451
Comment on attachment 8698336 [details] [review]
[gaia] gasolin:issue-1232588 > mozilla-b2g:master

Looks good, Fred, just one nit
Attachment #8698336 - Flags: review?(yzenevich) → review+
Issue addressed, merged to master https://github.com/mozilla-b2g/gaia/commit/d17ea22bb305f5473ab4721b4a7a5fd0f2e62836

thanks!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: