wrap Media Storage panel into AMD module

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gasolin@mozilla.com, Assigned: gasolin@mozilla.com)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We'd quickly wrap Media Storage panel to fit panel architecture, then refactor with Bug 973451 when we refocus on phone
Created attachment 8698336 [details] [review]
[gaia] gasolin:issue-1232588 > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Assignee: nobody → gasolin
tracking-b2g: --- → backlog
(Assignee)

Comment 2

3 years ago
Comment on attachment 8698336 [details] [review]
[gaia] gasolin:issue-1232588 > mozilla-b2g:master

Due to priority shift, I'd rather wrap rest of js into AMD panels even without refactor & adding unit tests. Test fine on device.
Attachment #8698336 - Flags: review?(yzenevich)
(Assignee)

Updated

3 years ago
Blocks: 973451
Comment on attachment 8698336 [details] [review]
[gaia] gasolin:issue-1232588 > mozilla-b2g:master

Looks good, Fred, just one nit
Attachment #8698336 - Flags: review?(yzenevich) → review+
(Assignee)

Comment 4

3 years ago
Issue addressed, merged to master https://github.com/mozilla-b2g/gaia/commit/d17ea22bb305f5473ab4721b4a7a5fd0f2e62836

thanks!
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.