Closed Bug 1232614 Opened 9 years ago Closed 8 years ago

JSON Viewer: visual expand[ed] indicators feel a bit old

Categories

(DevTools :: JSON Viewer, defect)

defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: Honza, Assigned: Honza)

References

Details

Attachments

(1 file)

The [+] and [-] indicators on the left of keys with expandable values (objects, arrays) feels like something from older Windows OSes. Maybe use the triangle used in the DevTools inspector's dom tree?

See also:
https://bugzilla.mozilla.org/show_bug.cgi?id=1223143#c7

Honza
Assignee: nobody → odvarko
Blocks: 1223143
Comment on attachment 8698400 [details] [diff] [review]
bug1232614-1.patch

Review of attachment 8698400 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #8698400 - Flags: review?(jryans) → review+
https://hg.mozilla.org/mozilla-central/rev/e066b36293fa
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	        beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: