1232715 - Bootstrap ignores --no-interactive flag when using dnf groupinstall

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brian J Murray]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.80 Safari/537.36

Steps to reproduce:

Run  python/mozboot/bin/bootstrap.py --no-interactive


Actual results:

There is a a prompt when installing DNF groups


Expected results:

DNF groups should install without prompting

Comment 1

[Brian J Murray]

Attachment: Bootstrap ignore --no-interactive flag when using dnf groupinstall

Comment 2

[Brian J Murray]

Attachment: Bootstrap ignores --no-interactive flag when using dnf groupinstall

Comment 3

[Brian J Murray]

Comment on attachment 8698507 [details] [diff] [review]
Bootstrap ignores --no-interactive flag when using dnf groupinstall

># HG changeset patch
># User Brian Murray <[e-mail]>
># Date 1450201360 28800
>#      Tue Dec 15 09:42:40 2015 -0800
># Node ID 5a98591a5b669fa3ceeb51cf9704bd40225bb151
># Parent  8d017f2740c6ed7cba5c008ddccacfdb0333bd41
>Bug 1232715 - Bootstrap ignores --no-interactive flag when using dnf groupinstall
>
>diff --git a/python/mozboot/mozboot/base.py b/python/mozboot/mozboot/base.py
>--- a/python/mozboot/mozboot/base.py
>+++ b/python/mozboot/mozboot/base.py
>@@ -170,16 +170,19 @@ class BaseBootstrapper(object):
> 
>         self.run_as_root(command)
> 
>     def dnf_groupinstall(self, *packages):
>         if self.which('dnf'):
>             command = ['dnf', 'groupinstall']
>         else:
>             command = ['yum', 'groupinstall']
>+
>+        if self.no_interactive:
>+            command.append('-y')
>         command.extend(packages)
> 
>         self.run_as_root(command)
> 
>     def dnf_update(self, *packages):
>         if self.which('dnf'):
>             command = ['dnf', 'update']
>         else:

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8698507 [details] [diff] [review]
Bootstrap ignores --no-interactive flag when using dnf groupinstall

Review of attachment 8698507 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I'll land this for you. Thanks for the fix.

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d68a410677b5c42274165d5ae062480bb933d0a7
Bug 1232715 - Bootstrap ignores --no-interactive flag when using dnf groupinstall; r=gps

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d68a410677b5

Comment 7

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS				Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected