1232719 - Extract search term to display in urlbar by reverse-parsing search url

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Users can see their highlighted search term in the urlbar only if they haven't clicked on any links, including "next" in search engine result pages. We should show the search term as long as they are on a search results page by reverse-parsing the search url.

Comment 1

[:Margaret Leibovic]

Emily, do you have a link to how we do this for iOS?

I know we have some code to do this in the search activity:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/search/java/org/mozilla/search/providers/SearchEngine.java#223

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We run the risk of having search providers change search urls underneath us, breaking this feature. If we decide to go ahead with it anyway, we should add some error handling to handle an unknown url (which probably will just put the url in the toolbar instead).

It'd be good to have some automated tests with live urls for this too. ;)

Comment 3

[Emily Toop (:fluffyemily)]

You can find the code for extracting the search term from the search templates here:

https://github.com/mozilla/firefox-ios/blob/5ac33f075b03887135bf8cd3efccd97f043112aa/Client/Frontend/Browser/OpenSearch.swift#L74

Comment 4

[:Margaret Leibovic]

(In reply to Michael Comella (:mcomella) from comment #2)
> We run the risk of having search providers change search urls underneath us,
> breaking this feature. If we decide to go ahead with it anyway, we should
> add some error handling to handle an unknown url (which probably will just
> put the url in the toolbar instead).
> 
> It'd be good to have some automated tests with live urls for this too. ;)

Well, worst case, we'll just show what we show right now.

While, yes, the providers can redirect, they can't change the URLs we use in our search plugins without us knowing about it.

This would be a good candidate for a JUnit test. We have a test for the search activity, but of course it isn't in mozilla-central...
https://bugzilla.mozilla.org/show_bug.cgi?id=1072429

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.