Change the `make xpi` command to produce a clean xpi that is suitable for uploading/publishing

RESOLVED FIXED

Status

Hello (Loop)
Client
P1
normal
Rank:
11
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [github-addon-ship])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Currently the `make xpi` command produces something that includes tests, .eslintrc files etc. We need to produce an xpi which is just the required parts.

I think the best thing here would be to use a dist to create a clean directory, which we then generate the xpi from.

This bug will ignore locale issues, we'll deal with those in a follow-up.
(Assignee)

Comment 1

2 years ago
Probably also depends on bug 1232707 as some of this is overlapping work.
Rank: 16
Depends on: 1232707
Priority: -- → P1
(Assignee)

Updated

2 years ago
Blocks: 1233045
(Assignee)

Updated

2 years ago
Assignee: nobody → standard8

Comment 2

2 years ago
Created attachment 8700783 [details] [review]
[loop] Standard8:bug-1232720-xpi > mozilla:master
(Assignee)

Comment 3

2 years ago
Comment on attachment 8700783 [details] [review]
[loop] Standard8:bug-1232720-xpi > mozilla:master

Mike, Chris, could one of you review this please?

This gets us preprocessing of the xpi, and a `make dist` command that generates the xpi for us.

There's probably some parts that could be improved, but I think its fairly good as it is for now, and we can ship an xpi with this.
Attachment #8700783 - Flags: review?(mdeboer)
Attachment #8700783 - Flags: review?(crafuse)
(Assignee)

Comment 4

2 years ago
I've just pushed a slight update to the PR to make sure that the xpi is generated every time the `make dist` command is run.
(Assignee)

Updated

2 years ago
Attachment #8700783 - Flags: review?(edilee)
(Assignee)

Updated

2 years ago
No longer depends on: 1232707
(Assignee)

Updated

2 years ago
Blocks: 1232707
(Assignee)

Comment 5

2 years ago
Comment on attachment 8700783 [details] [review]
[loop] Standard8:bug-1232720-xpi > mozilla:master

Ed has been looking at this.
Attachment #8700783 - Flags: review?(mdeboer)
Attachment #8700783 - Flags: review?(crafuse)
(Assignee)

Updated

2 years ago
Rank: 16 → 11

Comment 6

2 years ago
Comment on attachment 8700783 [details] [review]
[loop] Standard8:bug-1232720-xpi > mozilla:master

r=Mardak looks good with minor spacing nits
Attachment #8700783 - Flags: review?(edilee) → review+
(Assignee)

Comment 7

2 years ago
https://github.com/mozilla/loop/commit/1942f25198436cf77a9dcd860092d5bbcd6ea77f
Status: NEW → RESOLVED
Iteration: --- → 46.2 - Jan 11
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.