Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Enable OSX's CEMPEngine by default

RESOLVED FIXED in Firefox 46

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1223540 +++
I experimented a bit with CEMPengine and the performance is generally very good.

We discussed this during the last WebGL session in Orlando. The consensus was that the approach is interesting and that we should consider shipping it if it's not much work. Our plan is to turn on the feature and if it proves problematic to ship we will disable it.

On the Unity benchmark[1] I get a 15% speed improvement (86856 vs. 100044).

The outcome of this will likely inform how we want to pursue remoting GL to another thread and/or process for performance reason.

[1] http://beta.unity3d.com/jonas/WebGLBenchmark/
(Assignee)

Updated

2 years ago
Summary: Add a pref for CGL's multithreaded mode (CEMPEngine) → Enable OSX's CEMPEngine by default
(Assignee)

Comment 1

2 years ago
Created attachment 8698535 [details] [diff] [review]
patch
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #8698535 - Flags: review?(jmuizelaar)
(Assignee)

Comment 2

2 years ago
This feature might be a good candidate for fuzzing. In the past jruderman did a 'drive-by' fuzzing of OSX's accelerated canvas feature when we were thinking of enabling it. Based on these results we decided not to ship the feature. Fuzzing here could be beneficial. General rendering fuzzing and WebGL fuzzing on the mac platform with this feature turned on should trigger the new code path.
Flags: needinfo?(abillings)
(Assignee)

Comment 3

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=36c6c0abc1b6
Comment on attachment 8698535 [details] [diff] [review]
patch

Review of attachment 8698535 [details] [diff] [review]:
-----------------------------------------------------------------

Wait for 46
Attachment #8698535 - Flags: review?(jmuizelaar) → review+
I'll mention the fuzzing aspect to the team. Thanks for pinging me on it, Benoit.
Flags: needinfo?(abillings)

Comment 6

2 years ago
Already randomizing the pref in DOMFuzz:
https://github.com/MozillaSecurity/funfuzz/commit/9fef5bea3be144c526e1910b76a287c05b8f68c9

Anything new I need to do to fuzz this code well?
(Assignee)

Comment 7

2 years ago
Cool, I figured that might of been the case but I'm not familiar with how preferences are picked up.

As long as the fuzzing includes WebGL / web content on Mac then we should be covered. I'm assuming here that no news is good news.

Thanks!
(Assignee)

Comment 8

2 years ago
I'll enable this in early Jan 2016. If anything goes wrong I'll be more responsive to back it out then. NI for landing reminder.
Flags: needinfo?(bgirard)
(Assignee)

Comment 9

2 years ago
I'm leaving out the 'gfxPrefs.h' hunk. If the pref isn't read for some reason it can default to false.
Flags: needinfo?(bgirard)

Comment 10

2 years ago
Apparently you landed this patch with the wrong number (1223540). Am I right?
Flags: needinfo?(bgirard)
(Assignee)

Comment 11

2 years ago
That's correct. It should of been this bug # :(
Flags: needinfo?(bgirard)

Comment 12

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a8b0fc58afea139dbe815a3ba74d19d5cef017a (landed yesterday)
https://hg.mozilla.org/mozilla-central/rev/0a8b0fc58afe (landed today)
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.