Closed Bug 1232750 Opened 9 years ago Closed 5 years ago

Find all places that do a parse of source file in debugger and make sure they don't try on very large JS files

Categories

(DevTools :: Debugger, defect)

45 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: bgrins, Unassigned)

References

Details

Just as we fixed in Bug 1224726, we need to be careful to not use Parser.jsm on very large source files as it creates lot of memory usage and causes hangs.

Possible other uses:
* When the debugger is paused you can hover a variable and it'll show a tooltip of it's value
* When you cmd+click on a function thing to jump to the source

We can modify the new browser_dbg_sources-large.js test to cover these cases
Alternatively we could look into making Parser.jsm / Reflect.jsm not hang on these files
Or make the parse happen in a worker thread like pretty printing does.  Although in most of these cases the ux would require immediate feedback so waiting for the worker to finish is probably not an option.
Product: Firefox → DevTools

The debugger no longer uses parser.jsm so we should be alright.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.