1232807 - Expose "Request Desktop Site" through the "Share" menu

Status: VERIFIED FIXED

(Firefox for iOS :: General, enhancement, P5)

Description

[Karen Rudnitski [:kar]]

 **Requirements:**

- Provide users with access to RDS and Find in Page through the "Share" menu (like Safari)  

**User Stories:**

- As a user, I want to e able to have an easy and quick access to Request Desktop Site
- As a user, I want to e able to have an easy and quick access to Find in Page  

- 

**Acceptance Criteria:**

- I can find the RDS and Find in Page quickly

Comment 2

[Brian Nicholson (:bnicholson)]

We already have the RDS strings, and I plan on implementing the FIP part of this in bug 1164067. Moving the [needstrings] flag to that bug and morphing this one.

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1358

Robin, you can try this out if you want. I'll go ahead and include the assets whenever they're ready!

Comment 4

[Robin Andersen [:tecgirl]]

Attachment: ShareActionIcons.zip

:bnicholson here are all of the new Share Action icons. 

I tried your PR and saw the option, but experienced a locking crash when tapping on it.

Comment 5

[Robin Andersen [:tecgirl]]

Attachment: RMS!

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8699280 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1358

Think this is ready to land now.

Comment 7

[Robin Andersen [:tecgirl]]

Comment on attachment 8699280 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1358

It works! Looks good!

Comment 8

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8699280 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1358

LGTM! Works too! :)

Comment 9

[Brian Nicholson (:bnicholson)]

master: 3cec293e
v1.x: 42395af