Closed Bug 1232864 Opened 4 years ago Closed 4 years ago

Cauterize and release WebGL 2 to Nightly, but not Beta/Release

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed
relnote-firefox --- 51+

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

(Keywords: feature)

Attachments

(6 files)

We're close. Let's disable the broken bits and release what we have to Nightly.
Attachment #8698740 - Flags: review?(jmuizelaar)
Attachment #8698741 - Flags: review?(jmuizelaar)
Attachment #8698742 - Flags: review?(jmuizelaar)
Attachment #8698745 - Flags: review?(jmuizelaar)
Attachment #8698745 - Flags: feedback?(dglastonbury)
Attachment #8698740 - Flags: review?(jmuizelaar) → review+
Attachment #8698741 - Flags: review?(jmuizelaar) → review+
Attachment #8698742 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8698745 [details] [diff] [review]
0004-Enable-cauterized-WebGL-2-on-NIGHTLY_BUILD.patch

Review of attachment 8698745 [details] [diff] [review]:
-----------------------------------------------------------------

I'd prefer something like this so people can still disable it for testing if need be, but I approve of the idea in general.

diff --git a/modules/libpref/init/all.js b/modules/libpref/init/all.js
index ab4fc87..8a05194 100644
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -4197,17 +4197,21 @@ pref("webgl.default-no-alpha", false);
 pref("webgl.force-layers-readback", false);
 pref("webgl.lose-context-on-memory-pressure", false);
 pref("webgl.can-lose-context-in-foreground", true);
 pref("webgl.restore-context-when-visible", true);
 pref("webgl.max-warnings-per-context", 32);
 pref("webgl.enable-draft-extensions", false);
 pref("webgl.enable-privileged-extensions", false);
 pref("webgl.bypass-shader-validation", false);
+#ifdef NIGHTLY_BUILD
+pref("webgl.enable-prototype-webgl2", true);
+#else
 pref("webgl.enable-prototype-webgl2", false);
+#endif
 pref("webgl.disable-fail-if-major-performance-caveat", false);
 pref("webgl.disable-DOM-blit-uploads", false);
 pref("webgl.webgl2-compat-mode", false);
 
 #ifdef RELEASE_BUILD
 // Keep this disabled on Release and Beta for now. (see bug 1171228)
 pref("webgl.enable-debug-renderer-info", false);
 #else
Attachment #8698745 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8698745 [details] [diff] [review]
0004-Enable-cauterized-WebGL-2-on-NIGHTLY_BUILD.patch

Review of attachment 8698745 [details] [diff] [review]:
-----------------------------------------------------------------

I agree with jrmuizel.
Attachment #8698745 - Flags: feedback?(dglastonbury) → feedback+
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: WebGL 2 implemented
[Links (documentation, blog post, etc)]: I guess we will have some docs before the release.

AFAIK, it won't ship with 46.
relnote-firefox: --- → ?
(In reply to Sylvestre Ledru [:sylvestre] from comment #13)
> Release Note Request (optional, but appreciated)
> [Why is this notable]:
> [Suggested wording]: WebGL 2 implemented
> [Links (documentation, blog post, etc)]: I guess we will have some docs
> before the release.
> 
> AFAIK, it won't ship with 46.

What version/train specifically are the notes for? We have it turned on in Nightly, but we're not letting it ride trains unless we're done with it. (Which we aren't fully, yet)
Flags: needinfo?(sledru)
No version for now. The "?" is just a todo item. We will process it when we know in which version this will ship it.
Flags: needinfo?(sledru)
I think we may want to track this as a feature.
Keywords: feature
Are there any plans to re-enable the sampler-objects or add a flag to re-enable them in one of the next builds?

Unfortunately one of my projects use them and I can't update to the latest nightly until there is a way to re-enable the sampler-objects.
(In reply to Timo Sturm from comment #17)
> Are there any plans to re-enable the sampler-objects or add a flag to
> re-enable them in one of the next builds?

Bug 1230089 has a patch waiting review that should help. Hopefully it will get in soon.
Will this be enabled for 46 aurora?
Flags: needinfo?(jgilbert)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #19)
> Will this be enabled for 46 aurora?

No. It will be disabled for Aurora46, but enabled for Nightly47.
Flags: needinfo?(jgilbert)
Is there any News regarding the Samplers in Nightly47?
It looks like they are still disabled.
Flags: needinfo?(jgilbert)
Adding tracking for 47 since this is a new feature. Marking 46 as disabled.
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #22)
> Adding tracking for 47 since this is a new feature. Marking 46 as disabled.

This will not be riding the trains yet.
This also isn't really the best bug for this.

We don't have a bug for 'release WebGL 2 further than Nightly' yet, so there's not much to track on a micro-level.
(In reply to Timo Sturm from comment #21)
> Is there any News regarding the Samplers in Nightly47?
> It looks like they are still disabled.

I'll check.
(In reply to Jeff Gilbert [:jgilbert] from comment #24)
> (In reply to Timo Sturm from comment #21)
> > Is there any News regarding the Samplers in Nightly47?
> > It looks like they are still disabled.
> 
> I'll check.

Thanks!
re-setting this to "disabled" for 46 since code landed but it's preffed off past nightly (currently nightly 48)
Flags: needinfo?(jgilbert)
AFAIK, 51 is now the official target
Target Milestone: mozilla46 → mozilla51
This is included in the release notes for 51.
Summary: Cauterize and release WebGL 2 to Nightly → Cauterize and release WebGL 2 to Nightly, but not Beta/Release
Target Milestone: mozilla51 → mozilla46
You need to log in before you can comment on or make changes to this bug.