1232910 - Use channel.asyncOpen2 within dom/push/PushServiceHttp2.jsm

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1232910_asyncopen2_dom_push.patch

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Please see also:
https://bugzilla.mozilla.org/show_bug.cgi?id=1232430#c3

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8698801 [details] [diff] [review]
bug_1232910_asyncopen2_dom_push.patch

Review of attachment 8698801 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming that you checked the below and that it wasn't used.

::: dom/push/PushServiceHttp2.jsm
@@ +534,5 @@
>  
>      chan.notificationCallbacks = listener;
>  
>      try {
> +      chan.asyncOpen2(listener);

Did you check that the listener doesn't use the passed in context?

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1232910_asyncopen2_dom_push.patch

Just rebased the patch and added dragana as a reviewer. Carrying over r+.

(In reply to Jonas Sicking (:sicking) from comment #3)
> >      try {
> > +      chan.asyncOpen2(listener);
> 
> Did you check that the listener doesn't use the passed in context?

Yes, as verified with Dragana in Comment 2, that should be fine.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/39f56e62c694

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/39f56e62c694