Closed Bug 1232910 Opened 4 years ago Closed 4 years ago

Use channel.asyncOpen2 within dom/push/PushServiceHttp2.jsm

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → mozilla
Blocks: 1232430
Status: NEW → ASSIGNED
Attachment #8698801 - Flags: review?(jonas)
Comment on attachment 8698801 [details] [diff] [review]
bug_1232910_asyncopen2_dom_push.patch

Review of attachment 8698801 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming that you checked the below and that it wasn't used.

::: dom/push/PushServiceHttp2.jsm
@@ +534,5 @@
>  
>      chan.notificationCallbacks = listener;
>  
>      try {
> +      chan.asyncOpen2(listener);

Did you check that the listener doesn't use the passed in context?
Attachment #8698801 - Flags: review?(jonas) → review+
Just rebased the patch and added dragana as a reviewer. Carrying over r+.

(In reply to Jonas Sicking (:sicking) from comment #3)
> >      try {
> > +      chan.asyncOpen2(listener);
> 
> Did you check that the listener doesn't use the passed in context?

Yes, as verified with Dragana in Comment 2, that should be fine.
Attachment #8698801 - Attachment is obsolete: true
Attachment #8709820 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/39f56e62c694
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.