1232963 - taskcluster-github: http://references.taskcluster.net/github/v1/api.json is invalid against http://schemas.taskcluster.net/base/v1/api-reference.json

Status: RESOLVED FIXED

Description

[Pete Moore [:pmoore][:pete] (on PTO - back 25 Sep)]

"stability" is missing

Comment 1

[Pete Moore [:pmoore][:pete] (on PTO - back 25 Sep)]

Note, this meant I needed to temporarily ignore this problem in taskcluster-client-go:

https://github.com/taskcluster/taskcluster-client-go/commit/a80e7b9776eece7c2503838efc9d0ef4af3ccd61

When the taskcluster-github schema is fixed, this commit should be reverted (backed out).

Comment 2

[Pete Moore [:pmoore][:pete] (on PTO - back 25 Sep)]

Created attachment 8698879 [details] [review]
Github PR for taskcluster-github

Just bumped the taskcluster-base version in an attempt to fix this.

Comment 3

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8698879 [details] [review]
Github PR for taskcluster-github

See comment on github...

Comment 4

[Pete Moore [:pmoore][:pete] (on PTO - back 25 Sep)]

Comment on attachment 8698879 [details] [review]
Github PR for taskcluster-github

Can you re-review with the latest commit pushed to the PR?

Comment 5

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8698879 [details] [review]
Github PR for taskcluster-github

clearing flag as this was fixed...

Comment 6

[Jonas Finnemann Jensen (:jonasfj)]

Please resolve the bug when you've deployed :)

Comment 7

[Pete Moore [:pmoore][:pete] (on PTO - back 25 Sep)]

Jake: note, if successful, after deployment to heroku, http://references.taskcluster.net/github/v1/api.json will contain an entry "stability" for each api endpoint.

If after deployment this isn't the case, this bug needs to stay open, as more work will need to be done...

Thanks!

Comment 8

[Jake Watkins [:dividehex]]

"stability": "experimental",

Deployed and api response looks good. Marking resolved/fixed