There is no error message if you don't put an actual local blobfree zip file

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jlorenzo, Assigned: gerard-majax)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
STR
1. Select a local random file (like a text file)
2. Click on "Flash device"

Results
You're stuck at the "Extracting Build" step. There is no error message visible from the UI. This can be confusing for a user that is not used to the addon and the type of build to flash.

However, in the WebConsole, with the debug traces on, you get:
> Extracting blob free distribution: /path/to/my/wrong/file.txt about.js:859:3
> Dealing with /path/to/my/wrong/file.txt about.js:617:3
> Extracting blob free content: undefined about.js:865:5
> TypeError: invalid path component
> Stack trace:
> join@resource://gre/modules/osfile/ospath_unix.jsm:90:1
> extractBlobFreeContent@chrome://b2g-installer/content/about.js:660:36
> distributionStep/<@chrome://b2g-installer/content/about.js:866:12
> promise callback*distributionStep@chrome://b2g-installer/content/about.js:863:10
> step/<@chrome://b2g-installer/content/about.js:1140:12
> promise callback*install@chrome://b2g-installer/content/about.js:1181:3
> EventListener.handleEvent*load@chrome://b2g-installer/content/about.js:1290:1
> EventListener.handleEvent*@chrome://b2g-installer/content/about.js:1283:1
>  about.js:904:5
> 
> Installing failed about.js:1190:7
> 
> undefined about.js:1191:7
(Assignee)

Comment 1

3 years ago
Created attachment 8714803 [details] [review]
PR
Assignee: nobody → lissyx+mozillians
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8714840 [details]
Capture du 2016-02-02 16-57-42.png
(Assignee)

Comment 3

3 years ago
Created attachment 8714841 [details]
Capture du 2016-02-02 16-58-00.png
(Assignee)

Comment 4

3 years ago
(In reply to Alexandre LISSY :gerard-majax from comment #3)
> Created attachment 8714841 [details]
> Capture du 2016-02-02 16-58-00.png

That matches the use reported in this bug: invalid blobfree distribution.
(Assignee)

Comment 5

3 years ago
(In reply to Alexandre LISSY :gerard-majax from comment #2)
> Created attachment 8714840 [details]
> Capture du 2016-02-02 16-57-42.png

Also makes error reporting better when anything fails in the chain.
(Assignee)

Updated

3 years ago
Attachment #8714803 - Flags: review?(dale)
(Assignee)

Comment 6

3 years ago
Created attachment 8714919 [details] [review]
https://github.com/mozilla-b2g/b2g-installer/pull/34

Same PR with the proper bug number
Attachment #8714803 - Attachment is obsolete: true
Attachment #8714803 - Flags: review?(dale)
Attachment #8714919 - Flags: review?(dale)
Comment on attachment 8714919 [details] [review]
https://github.com/mozilla-b2g/b2g-installer/pull/34

This looks good, cheers
Attachment #8714919 - Flags: review?(dale) → review+
(Assignee)

Comment 8

3 years ago
https://github.com/mozilla-b2g/b2g-installer/commit/372c13b06b21ba92a9c8d1a785971e9690d9f24a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.