Closed Bug 1233019 Opened 4 years ago Closed 4 years ago

Custom file is persisted after a page refresh, creating a confusing UI

Categories

(Firefox OS Graveyard :: B2gInstaller, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlorenzo, Assigned: gerard-majax)

References

Details

Attachments

(3 files, 1 obsolete file)

Attached image Screenshot
STR
1. Pick a custom local file => Notice it appears now as an option in the <ul> list
2. Refresh the page

Expected results
After a refresh, either the file name next to the "browse" button is cleared, or the file remains an option in the <ul> list.

Actual results
See attached screenshot. The choice become unclear: What happens if I click on nightly but my file is still next to the "browse" button, which one will be picked? 
How can I clear the file name if I don't want to use the local file anymore?
Assignee: nobody → lissyx+mozillians
Helper methods are introduced in bug 1235459 within common.js
Depends on: 1235459
Comment on attachment 8703622 [details] [diff] [review]
Reloading about:b2g-installer should cleanup custom build file entry

Works manually fine from my side!
Attachment #8703622 - Flags: qa-approval+
Comment on attachment 8703622 [details] [diff] [review]
Reloading about:b2g-installer should cleanup custom build file entry

Review of attachment 8703622 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, tests are awesome, thanks
Attachment #8703622 - Flags: review?(dale) → review+
I did some refactoring and added more Promise() to make the runTest() function nicer.
Attachment #8703622 - Attachment is obsolete: true
Attachment #8704048 - Flags: review+
Attached file PR of the patch
Splitting in two parts for: PR to integrate in current addon, and remaining tests will be squashed into bug 1235459
Attachment #8706269 - Flags: review+
https://github.com/mozilla-b2g/b2g-installer/commit/c345d342757cba3e9b823912ea57effadc9ede0c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.