1233019 - Custom file is persisted after a page refresh, creating a confusing UI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: B2gInstaller, defect)

Description

[Johan Lorenzo [:jlorenzo] - PTO - Back August 24th]

Attachment: Screenshot

STR
1. Pick a custom local file => Notice it appears now as an option in the <ul> list
2. Refresh the page

Expected results
After a refresh, either the file name next to the "browse" button is cleared, or the file remains an option in the <ul> list.

Actual results
See attached screenshot. The choice become unclear: What happens if I click on nightly but my file is still next to the "browse" button, which one will be picked? 
How can I clear the file name if I don't want to use the local file anymore?

Comment 1

[:gerard-majax]

Attachment: Reloading about:b2g-installer should cleanup custom build file entry

Comment 2

[:gerard-majax]

Helper methods are introduced in bug 1235459 within common.js

Comment 3

[Johan Lorenzo [:jlorenzo] - PTO - Back August 24th]

Comment on attachment 8703622 [details] [diff] [review]
Reloading about:b2g-installer should cleanup custom build file entry

Works manually fine from my side!

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8703622 [details] [diff] [review]
Reloading about:b2g-installer should cleanup custom build file entry

Review of attachment 8703622 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, tests are awesome, thanks

Comment 5

[:gerard-majax]

Attachment: Reloading about:b2g-installer should cleanup custom build file entry

I did some refactoring and added more Promise() to make the runTest() function nicer.

Comment 6

[:gerard-majax]

Attachment: PR of the patch

Splitting in two parts for: PR to integrate in current addon, and remaining tests will be squashed into bug 1235459

Comment 7

[:gerard-majax]

https://github.com/mozilla-b2g/b2g-installer/commit/c345d342757cba3e9b823912ea57effadc9ede0c