Closed Bug 1233045 Opened 9 years ago Closed 8 years ago

Make a dist directory with code that's releasable for loop-client servers

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: standard8, Assigned: dcritchley)

References

(
URL
)

Details

User Story

Approximate technical checklist:
Approximate tech checklist:

X port old standalone_dist target to become dist_standalone target
* do minimal path-related changes to get all symbols resolving
XX get most libraries from node_modules rather than shared/vendor
** get webpack configured to use babel-loader for transforms
* figure out how we want to run dev server against dist/standalone vs. built/standalone
* test a call using local loop server and dist/standalone
* fix all non-resolved symbols there

Key resources include asking dmose, Mardak, or Standard8; the webpack docs, and Pete Hunt's webpack howto.  Don't block on docs for long; ask someone.

Attachments

(2 files)

[loop] daveccrit:1233045-makeDist > mozilla:master
39 bytes, text/x-github-pull-request
Details | Review
Link to Github pull-request: https://github.com/mozilla/loop/pull/99
39 bytes, text/x-github-pull-request
standard8
: review+
Details | Review 
We need to make a dist directory that's suitable for releasing loop-client from. The idea is that at some stage we'll drop the existing loop-client repo. 

Something like dist/client or dist/standalone. Within the directory should be only the files that are the ones we ship.

Ideally, the layout should be virtually identical to that given from "make dist" in loop-client. This includes the pre-processing/concatenation of the files.

This bug can ignore L10n for now.

We probably want to do this after bug 1232720 and/or bug 1232707 as they are touching similar areas.
Rank: 19
Priority: -- → P1
Whiteboard: [has bugs blocking]
It would be nice to ensure we take account of bug 1062959 when we do this - to have react shipped in production mode in dist. If we need an option for debug vs prod, we can always deal with that later.

Although I think the existing react is already shipped in production mode by webpack in the loop-client repo, so the action here is probably to make sure that's maintained.
Depends on: 1062959
Blocks: 1062959
No longer depends on: 1062959
Assignee: nobody → crafuse
Status: NEW → ASSIGNED
Assignee: crafuse → dcritchley
Blocks: 1239839
Whiteboard: [has bugs blocking]
User Story: (updated)
User Story: (updated)
Comment on attachment 8710778 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/99

r=Standard8 with the comments fix.

Please try and land today, I'll hopefully get time to get the dev server up and running again.
Attachment #8710778 - Flags: review?(standard8)
Attachment #8710778 - Flags: review?(dmose)
Attachment #8710778 - Flags: review+
URL: https://github.com/mozilla/loop/commi...
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: