Closed Bug 1233061 Opened 4 years ago Closed 4 years ago

add override declarations for MessagePumpForNonMainUIThreads

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

This change silences a small number of warnings when compiling with
clang-cl.  In passing, it also deletes some carriage return characters
that have crept in.
Comment on attachment 8698991 [details] [diff] [review]
add override declarations for MessagePumpForNonMainUIThreads

Review of attachment 8698991 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/glue/MessagePump.h
@@ +107,5 @@
>    // RefCountedThreadSafe.
> +  NS_IMETHOD_(MozExternalRefCountType) AddRef(void) override {
> +    return 2;
> +  }
> +  NS_IMETHOD_(MozExternalRefCountType) Release(void) override 

Looks like you're missing a brace.
Attachment #8698991 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/864c3f615270
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.