1233061 - add override declarations for MessagePumpForNonMainUIThreads

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Nathan Froyd [:froydnj]]

This change silences a small number of warnings when compiling with
clang-cl.  In passing, it also deletes some carriage return characters
that have crept in.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: add override declarations for MessagePumpForNonMainUIThreads

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8698991 [details] [diff] [review]
add override declarations for MessagePumpForNonMainUIThreads

Review of attachment 8698991 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/glue/MessagePump.h
@@ +107,5 @@
>    // RefCountedThreadSafe.
> +  NS_IMETHOD_(MozExternalRefCountType) AddRef(void) override {
> +    return 2;
> +  }
> +  NS_IMETHOD_(MozExternalRefCountType) Release(void) override 

Looks like you're missing a brace.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/864c3f615270

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/864c3f615270