1233128 - Links on windmobile.ca appear with strikethrough instead of underline

Status: NEW

(Core :: Layout: Text and Fonts, defect)

Description

[u279076]

When looking at content on windmobile.ca I noticed that links appear as strikethrough whereas in Chrome they appear underlined. I tested this back as far as Firefox 16 and it still reproduce so I don't think it's a regression on our end. Looking at links in the Inspector it appears the line height styling is insufficient. I'll attach some screenshots to illustrate.

Comment 1

[u279076]

Attachment: Screenshot: Chrome

Comment 2

[u279076]

Attachment: Screenshot: Firefox

Comment 3

[u279076]

Attachment: Screenshot: Inspector

Comment 4

[Chris Peterson [:cpeterson]]

I noticed the same "strikethrough instead of underline" problem today on the following site. Look for the bold text in the paragraphs, such as "burn the ships".

http://www.lukeshavak.com/inspirational/burn-your-ships/

Comment 5

[Boris Zbarsky [:bzbarsky]]

On the burn-your-ships page, this is due to the use of the "avantgarde_md_btmedium" font loaded from <http://www.lukeshavak.com/wp-content/themes/lukeshavak/css/fonts/avgardm.woff>.  Presumably it has bogus font metrics of some sort?

On windmobile.ca, the issue is with the GothamBook font loaded from https://www.windmobile.ca/Sitefinity/WebsiteTemplates/Freedom/App_Themes/Freedom/global/fonts/GothamSSm-Book.otf

Not a DOM issue in any way; either evangelism or (more likely, since multiple fonts are involved) text layout...

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I have no idea to fix this if the font metrics is odd. John-san might have some idea?

Comment 7

[John Daggett (:jtd)]

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #6)
> I have no idea to fix this if the font metrics is odd. John-san might have
> some idea?

I think it's the maxDescent value that's odd, it's negative.

Font: 0x131cb4080 (ufE1G9bUSwS3KZd-r+Na7adA==) size: 96.000000
    emHeight: 96.000000 emAscent: 128.603774 emDescent: -32.603774
    maxAscent: 71.000000 maxDescent: -18.000000 maxAdvance: 114.687500
    internalLeading: 0.000000 externalLeading: 8.156250
    spaceWidth: 26.578125 aveCharWidth: 54.546875 xHeight: 52.500000
    uOff: 19.000000 uSize: 1.000000 stOff: 33.656250 stSize: 4.781250

Compare with a standard font like Times:

Font: 0x12fe69580 (Times-Roman) size: 96.000000
    emHeight: 96.000000 emAscent: 72.000000 emDescent: 24.000000
    maxAscent: 72.000000 maxDescent: 24.000000 maxAdvance: 165.234375
    internalLeading: 0.000000 externalLeading: 0.000000
    spaceWidth: 24.000000 aveCharWidth: 48.000000 xHeight: 44.250000
    uOff: -7.265625 uSize: 4.734375 stOff: 22.125000 stSize: 4.734375

Seems like there's some code that's not getting sanitized properly in gfxFont::SanitizeMetrics or gfxFont::InitMetricsFromSfntTables.