ScriptLoader should cancel channel when aborting due to cancelation

RESOLVED FIXED in Firefox 46

Status

()

Core
DOM: Service Workers
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In bug 1229970 I added a short-circuit failure path if another script in the load was canceled or failed.  That avoided a crash.

I see now, though, that I did not cancel the channel.  All the other error paths do this and so should this one.
(Assignee)

Comment 1

3 years ago
Created attachment 8699137 [details] [diff] [review]
Cancel channel when ScriptLoader is aborted during service worker script load. r=khuey

Something I missed in the patch you reviewed for me last week.
Attachment #8699137 - Flags: review?(khuey)
Comment on attachment 8699137 [details] [diff] [review]
Cancel channel when ScriptLoader is aborted during service worker script load. r=khuey

Review of attachment 8699137 [details] [diff] [review]:
-----------------------------------------------------------------

Is it possible to test this somehow?
Attachment #8699137 - Flags: review?(khuey) → review+
(Assignee)

Comment 3

3 years ago
I don't know how to write a test for this that wouldn't be incredibly racy.  I think this change is clearly correct, though, so I would like to land it.

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bd4fe7efeb47
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.