Duplicated string first_time_experience_button_label in loop.properties

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: flod, Assigned: crafuse)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
http://hg.mozilla.org/mozilla-central/diff/ec836d27b563/browser/locales/en-US/chrome/browser/loop/loop.properties

There was already such string with a different value
first_time_experience_button_label=Get Started

Considering that, I expect English to not show the correct text either.
(Reporter)

Comment 1

3 years ago
NI for visibility, even if we're at the very beginning of the cycle.
Flags: needinfo?(crafuse)
(Assignee)

Comment 2

3 years ago
Dan, Does this need to happen in gecko-dev/Mozilla Central?

REMOVE:
first_time_experience_button_label=Get Started


Increment and translate for:
first_time_experience_button_label=See how it works
TO:
first_time_experience_button_label2=See how it works

Change to:
add-on/panels/js/panel.jsx
38:                  caption={mozL10n.get("first_time_experience_button_label2")}
Flags: needinfo?(crafuse) → needinfo?(dmose)
I have mixed feelings on this one.  Deferring to Standard8 in case he has a strong opinion...
Flags: needinfo?(standard8)
As this is broken, lets get it fixed on m-c so that its better for localisers for now.
Flags: needinfo?(standard8)
(Assignee)

Updated

3 years ago
Assignee: nobody → crafuse
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
FWIW, this issue causes a warning to be spammed to the terminal, too (during startup on debug builds at least):
  WARNING: the property first_time_experience_button_label already exists
  : file ../../../mozilla/xpcom/ds/nsPersistentProperties.cpp, line 532
(Assignee)

Comment 6

3 years ago
Created attachment 8699777 [details] [diff] [review]
Duplicated string first_time_experience_button_label in loop.properties
(Assignee)

Comment 7

3 years ago
Comment on attachment 8699777 [details] [diff] [review]
Duplicated string first_time_experience_button_label in loop.properties

Removed string property and modified display location.

Needs to eventually be synced with loop master.
Attachment #8699777 - Flags: review?(standard8)
Comment on attachment 8699777 [details] [diff] [review]
Duplicated string first_time_experience_button_label in loop.properties

Looks good. r=Standard8
Attachment #8699777 - Flags: review?(standard8) → review+
Flags: needinfo?(dmose)
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.