Closed Bug 1233208 Opened 6 years ago Closed 6 years ago

IOInterposer is enabled in beta

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox44 --- fixed
firefox45 --- fixed
firefox46 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

Details

Attachments

(1 file)

Change define to use RELEASE_BUILD
881 bytes, patch
froydnj
: review+
ritu
: approval-mozilla-aurora+
ritu
: approval-mozilla-beta+
lizzard
: approval-mozilla-release-
Details | Diff | Splinter Review 
That was never intended but I think it inadvertently happened due to some changes to when MOZ_ENABLE_PROFILER_SPS is set. Let's change the ifdefs to make this more sensible.
Comment on attachment 8699196 [details] [diff] [review]
Change define to use RELEASE_BUILD

Review of attachment 8699196 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.
Attachment #8699196 - Flags: review?(nfroyd) → review+
Comment on attachment 8699196 [details] [diff] [review]
Change define to use RELEASE_BUILD

(Adding release to suggest that this be a ride-along to any 43 chemspill)

Approval Request Comment
[Feature/regressing bug #]: IOInterposer
[User impact if declined]: Slower performance due to I/O reporting functionality being mistakenly enabled in Beta/Release
[Describe test coverage new/current, TreeHerder]: Any test that does file I/O will interact with the affected code, so I'd say it has extensive coverage.
[Risks and why]: Low, just disables something that used to be disabled previously.
[String/UUID change made/needed]: None
Attachment #8699196 - Flags: approval-mozilla-release?
Attachment #8699196 - Flags: approval-mozilla-beta?
Attachment #8699196 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/6aa41697cb73
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment on attachment 8699196 [details] [diff] [review]
Change define to use RELEASE_BUILD

Makes sense, taking it. Beta44+, Aurora45+
Attachment #8699196 - Flags: approval-mozilla-beta?
Attachment #8699196 - Flags: approval-mozilla-beta+
Attachment #8699196 - Flags: approval-mozilla-aurora?
Attachment #8699196 - Flags: approval-mozilla-aurora+
Comment on attachment 8699196 [details] [diff] [review]
Change define to use RELEASE_BUILD

This looks great but I want to minimize any more risk in 43.0.2. Good that we're fixing it in 44 though.
Attachment #8699196 - Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in before you can comment on or make changes to this bug.