Closed Bug 1233213 Opened 9 years ago Closed 9 years ago

[pulse_actions/push-extender] Better whitelist support

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: armenzg, Assigned: armenzg)

Details

Attachments

(1 file)

Pulse actions handles various TH actions. It seems that we only whitelisted philor for push extender. Let's fix it! https://github.com/mozilla/pulse_actions/commit/117a4cef8db1ee5f9bff5bc13e55a95e9b6e70b8
Dec 16 12:09:46 pulse-actions app/worker2.1: INFO: New jobs requested by philringnalda@gmail.com on repo_name try with resultset_id: 82044 Dec 16 12:09:47 pulse-actions app/worker2.1: root INFO: New jobs requested by philringnalda@gmail.com on repo_name try with resultset_id: 82044 Dec 16 12:09:48 pulse-actions app/worker2.1: Traceback (most recent call last): Dec 16 12:09:48 pulse-actions app/worker2.1: File "pulse_actions/worker.py", line 75, in run_pulse Dec 16 12:09:48 pulse-actions app/worker2.1: pulse.listen() Dec 16 12:09:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/mozillapulse/consumers.py", line 151, in listen Dec 16 12:09:48 pulse-actions app/worker2.1: self._drain_events_loop() Dec 16 12:09:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/mozillapulse/consumers.py", line 198, in _drain_events_loop Dec 16 12:09:48 pulse-actions app/worker2.1: self.connection.drain_events(timeout=self.timeout) Dec 16 12:09:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/kombu/connection.py", line 275, in drain_events Dec 16 12:09:48 pulse-actions app/worker2.1: return self.transport.drain_events(self.connection, **kwargs) Dec 16 12:09:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/kombu/transport/pyamqp.py", line 95, in drain_events Dec 16 12:09:48 pulse-actions app/worker2.1: return connection.drain_events(**kwargs) Dec 16 12:09:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/amqp/connection.py", line 325, in drain_events Dec 16 12:09:48 pulse-actions app/worker2.1: return amqp_method(channel, args, content) Dec 16 12:09:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/amqp/channel.py", line 1909, in _basic_deliver Dec 16 12:09:48 pulse-actions app/worker2.1: fun(msg) Dec 16 12:09:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/kombu/messaging.py", line 596, in _receive_callback Dec 16 12:09:48 pulse-actions app/worker2.1: return on_m(message) if on_m else self.receive(decoded, message) Dec 16 12:09:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/kombu/messaging.py", line 563, in receive Dec 16 12:09:48 pulse-actions app/worker2.1: [callback(body, message) for callback in callbacks] Dec 16 12:09:48 pulse-actions app/worker2.1: File "pulse_actions/worker.py", line 66, in handler_with_dry_run Dec 16 12:09:48 pulse-actions app/worker2.1: return event_handler(data, message, dry_run) Dec 16 12:09:48 pulse-actions app/worker2.1: File "/app/pulse_actions/handlers/route_functions.py", line 15, in route Dec 16 12:09:48 pulse-actions app/worker2.1: treeherder_runnable.on_runnable_job_prod_event(data, message, dry_run) Dec 16 12:09:48 pulse-actions app/worker2.1: File "/app/pulse_actions/handlers/treeherder_runnable.py", line 20, in on_runnable_job_prod_event Dec 16 12:09:48 pulse-actions app/worker2.1: return on_runnable_job_event(data, message, dry_run, stage=False) Dec 16 12:09:48 pulse-actions app/worker2.1: File "/app/pulse_actions/handlers/treeherder_runnable.py", line 66, in on_runnable_job_event Dec 16 12:09:48 pulse-actions app/worker2.1: requester) Dec 16 12:09:48 pulse-actions app/worker2.1: Exception: Requester philringnalda@gmail.com is not allowed to trigger jobs. Dec 16 12:22:47 pulse-actions app/worker2.1: INFO: New jobs requested by philringnalda@gmail.com on repo_name try with resultset_id: 82044 Dec 16 12:22:47 pulse-actions app/worker2.1: root INFO: New jobs requested by philringnalda@gmail.com on repo_name try with resultset_id: 82044 Dec 16 12:22:48 pulse-actions app/worker2.1: File "pulse_actions/worker.py", line 75, in run_pulse Dec 16 12:22:48 pulse-actions app/worker2.1: pulse.listen() Dec 16 12:22:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/mozillapulse/consumers.py", line 151, in listen Dec 16 12:22:48 pulse-actions app/worker2.1: self._drain_events_loop() Dec 16 12:22:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/mozillapulse/consumers.py", line 198, in _drain_events_loop Dec 16 12:22:48 pulse-actions app/worker2.1: self.connection.drain_events(timeout=self.timeout) Dec 16 12:22:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/kombu/connection.py", line 275, in drain_events Dec 16 12:22:48 pulse-actions app/worker2.1: return self.transport.drain_events(self.connection, **kwargs) Dec 16 12:22:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/kombu/transport/pyamqp.py", line 95, in drain_events Dec 16 12:22:48 pulse-actions app/worker2.1: return connection.drain_events(**kwargs) Dec 16 12:22:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/amqp/connection.py", line 325, in drain_events Dec 16 12:22:48 pulse-actions app/worker2.1: return amqp_method(channel, args, content) Dec 16 12:22:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/amqp/channel.py", line 1909, in _basic_deliver Dec 16 12:22:48 pulse-actions app/worker2.1: fun(msg) Dec 16 12:22:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/kombu/messaging.py", line 596, in _receive_callback Dec 16 12:22:48 pulse-actions app/worker2.1: return on_m(message) if on_m else self.receive(decoded, message) Dec 16 12:22:48 pulse-actions app/worker2.1: File "/app/.heroku/python/lib/python2.7/site-packages/kombu/messaging.py", line 563, in receive Dec 16 12:22:48 pulse-actions app/worker2.1: [callback(body, message) for callback in callbacks] Dec 16 12:22:48 pulse-actions app/worker2.1: File "pulse_actions/worker.py", line 66, in handler_with_dry_run Dec 16 12:22:48 pulse-actions app/worker2.1: return event_handler(data, message, dry_run) Dec 16 12:22:48 pulse-actions app/worker2.1: File "/app/pulse_actions/handlers/route_functions.py", line 15, in route Dec 16 12:22:48 pulse-actions app/worker2.1: treeherder_runnable.on_runnable_job_prod_event(data, message, dry_run) Dec 16 12:22:48 pulse-actions app/worker2.1: File "/app/pulse_actions/handlers/treeherder_runnable.py", line 20, in on_runnable_job_prod_event Dec 16 12:22:48 pulse-actions app/worker2.1: return on_runnable_job_event(data, message, dry_run, stage=False) Dec 16 12:22:48 pulse-actions app/worker2.1: File "/app/pulse_actions/handlers/treeherder_runnable.py", line 66, in on_runnable_job_event Dec 16 12:22:48 pulse-actions app/worker2.1: requester) Dec 16 12:22:48 pulse-actions app/worker2.1: Traceback (most recent call last): Dec 16 12:22:49 pulse-actions app/worker2.1: Exception: Requester philringnalda@gmail.com is not allowed to trigger jobs.
We were checking if the commit's author was whitelisted, but we should be checking if who made the request was whitelisted.
Attachment #8699223 - Flags: review?(armenzg)
Comment on attachment 8699223 [details] [review] Checking if the requester is whitelisted I merged this on the PR. I also merged master to the heroku branch and push. This should be live soon.
Attachment #8699223 - Flags: review?(armenzg) → review+
philor: please let us know when you try again so we can tell from the logs if it worked.
Summary: Better whitelist support → [pulse_actions/push-extender] Better whitelist support
I never seem to need to while you might be around, but I needed one this evening, triggered it, and it did work. Great success!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
\o/ Thanks philor for letting us know!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: