Closed
Bug 1233234
Opened 8 years ago
Closed 8 years ago
use UniquePtr<T[]> instead of nsAutoArrayPtr<T> in modules/libpref/
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(3 files)
1.47 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
5.03 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
1.61 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8699207 -
Flags: review?(n.nethercote)
Assignee | ||
Comment 2•8 years ago
|
||
Returning outparams with UniquePtr is not convenient or idiomatic, so in addition to removing nsAutoArrayPtr usage, let's return a UniquePtr from the function directly.
Attachment #8699209 -
Flags: review?(n.nethercote)
Assignee | ||
Comment 3•8 years ago
|
||
We shouldn't use .get() on UniquePtr<T[]> unless we have to, and it makes the code clearer to not use pointer incrementing in any event.
Attachment #8699210 -
Flags: review?(n.nethercote)
Updated•8 years ago
|
Attachment #8699207 -
Flags: review?(n.nethercote) → review+
Updated•8 years ago
|
Attachment #8699209 -
Flags: review?(n.nethercote) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8699210 [details] [diff] [review] part 3 - clean up UniquePtr usage in WritePrefFile Review of attachment 8699210 [details] [diff] [review]: ----------------------------------------------------------------- Much nicer.
Attachment #8699210 -
Flags: review?(n.nethercote) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad9829069924 https://hg.mozilla.org/integration/mozilla-inbound/rev/cb6e7e36a326 https://hg.mozilla.org/integration/mozilla-inbound/rev/ac0b0369ebd8
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ad9829069924 https://hg.mozilla.org/mozilla-central/rev/cb6e7e36a326 https://hg.mozilla.org/mozilla-central/rev/ac0b0369ebd8
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•