1233254 - "NS_ERROR_FAILURE: Failure" in several chrome JS files (EnsureContentViewer fails in nsDocShell::GetDocument)

Status: NEW

(Core :: DOM: Core & HTML, defect, P3)

Description

[Jesse Ruderman]

Attachment: testcase

> WARNING: NS_ENSURE_SUCCESS(EnsureContentViewer(), nullptr) failed with result 0x80004005: file base/nsDocShell.cpp, line 4438
> JavaScript error: resource://app/modules/sessionstore/FrameTree.jsm, line 204: NS_ERROR_FAILURE: Failure
> 
> WARNING: NS_ENSURE_SUCCESS(EnsureContentViewer(), nullptr) failed with result 0x80004005: file base/nsDocShell.cpp, line 4438
> JavaScript error: chrome://browser/content/tab-content.js, line 454: NS_ERROR_FAILURE: Failure
> 
> WARNING: NS_ENSURE_SUCCESS(EnsureContentViewer(), nullptr) failed with result 0x80004005: file base/nsDocShell.cpp, line 4438
> JavaScript error: resource://gre/modules/LoginManagerContent.jsm, line 403: NS_ERROR_FAILURE: Failure

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Regression range (when this first regressed, only the FrameTree.jsm error was present):
INFO: Last good revision: 9d8d16695f6a (2014-05-21)
INFO: First bad revision: b40296602083 (2014-05-22)
INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9d8d16695f6a&tochange=b40296602083

It still hits the below failures on trunk:
NS_ERROR_FAILURE: Failure  tab-content.js:470
NS_ERROR_FAILURE: Failure  LoginManagerContent.jsm:498

And indeed, it's still coming from:
WARNING: NS_ENSURE_SUCCESS(EnsureContentViewer(), nullptr) failed with result 0x80004005: file docshell/base/nsDocShell.cpp, line 4632

Which is coming from nsDocShell::GetDocument(), which was added by bug 966059 5 days after the regressing nightly (because what fun would that have been for them to have lined up).

Both callers have similar code patterns:
tab-content.jsm:470
> let subSheets = Array.map(frameset.frames, frame => this.getAllStyleSheets(frame));

LoginManagerContent.jsm:498
> Array.some(thisWindow.frames,

No idea if any of this helps either...